Skip to content

Conversation

@scorreard
Copy link
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

This PR is to correct the issue raised in #6664

Here is a breakdown of the changes :
When the lineage is set to auto
In that case, BUSCO runs a generic lineage analysis and then go to more specific ones to identify the best lineage for the species

  • Extract the names of the specific and generic lineages
  • Renames the files with "specific" or "generic" depending on which lineage was used to generate them
  • Output the results for both the generic and specific lineages for the output type requested by the user

When the lineage is selected by the user

  • Renames the files with "specific"
  • Output the results for the specific lineages for the output type requested by the user

I tested it locally and it behaved as expected.

@scorreard
Copy link
Contributor Author

Set to draft as we may want to add the test (#7209) before solving the issue

@bernt-matthias bernt-matthias self-requested a review August 14, 2025 17:07
@scorreard scorreard marked this pull request as ready for review August 20, 2025 11:03
@scorreard
Copy link
Contributor Author

Following feedback from @rlibouba, I'll make an update so that :

  • By default, only results from the specific lineage are displayed
  • Upon selection from the user, it will also show the results from the generic lineage in their history

Copy link
Contributor

@lsterck lsterck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @scorreard ! :-)
And excellent suggestion @rlibouba , thanks!

@scorreard scorreard requested a review from lsterck September 3, 2025 07:53
Copy link
Contributor

@lsterck lsterck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the test with the bacilli input removed? (or is that file simply renamed?)

@scorreard
Copy link
Contributor Author

was the test with the bacilli input removed? (or is that file simply renamed?)

Are you talking about the test developped in PR 7209?

@lsterck
Copy link
Contributor

lsterck commented Sep 4, 2025

was the test with the bacilli input removed? (or is that file simply renamed?)

Are you talking about the test developped in PR 7209?

ah, yes indeed.
or did we decide not to include it yet?
anyway, not a big point as the 'procedure' is tested with the current dataset as well.

@scorreard
Copy link
Contributor Author

was the test with the bacilli input removed? (or is that file simply renamed?)

Are you talking about the test developped in PR 7209?

ah, yes indeed. or did we decide not to include it yet? anyway, not a big point as the 'procedure' is tested with the current dataset as well.

I'd like to include it but we did not get replies from bgruening or bernt-matthias. Should I just include your code here? I think it would be great to include it

@bernt-matthias
Copy link
Contributor

I'd like to include it but we did not get replies from bgruening or bernt-matthias

I would say: yes :)

@scorreard
Copy link
Contributor Author

Ok, it should be in now, wiaiting for the tests to pass and then it's ready for review.

@scorreard
Copy link
Contributor Author

This PR includes :

  • An update to BUSCO outputs to deal with the multiple output with similar names
  • A new test to identify empty files in BUSCo ouptuts.

It's ready for reviews

Copy link
Contributor

@rlibouba rlibouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you!

@SaimMomin12 SaimMomin12 requested review from bgruening and rlibouba and removed request for rlibouba September 18, 2025 14:47
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this and then work on the 6.0 version :)

Thanks everyone!

@bgruening bgruening merged commit 1696bfc into galaxyproject:main Oct 4, 2025
11 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Oct 4, 2025

Attention: deployment skipped!

https://github.com/galaxyproject/tools-iuc/actions/runs/18247366074

@bernt-matthias
Copy link
Contributor

Send deployed

@scorreard scorreard deleted the busco_scorreard branch October 7, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants