-
Notifications
You must be signed in to change notification settings - Fork 483
BUSCO wrapper update to correct issue of empty table #7220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Set to draft as we may want to add the test (#7209) before solving the issue |
|
Following feedback from @rlibouba, I'll make an update so that :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @scorreard ! :-)
And excellent suggestion @rlibouba , thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was the test with the bacilli input removed? (or is that file simply renamed?)
Are you talking about the test developped in PR 7209? |
ah, yes indeed. |
I'd like to include it but we did not get replies from bgruening or bernt-matthias. Should I just include your code here? I think it would be great to include it |
I would say: yes :) |
|
Ok, it should be in now, wiaiting for the tests to pass and then it's ready for review. |
|
This PR includes :
It's ready for reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship this and then work on the 6.0 version :)
Thanks everyone!
|
Attention: deployment skipped! https://github.com/galaxyproject/tools-iuc/actions/runs/18247366074 |
|
Send deployed |
FOR CONTRIBUTOR:
This PR is to correct the issue raised in #6664
Here is a breakdown of the changes :
When the lineage is set to auto
In that case, BUSCO runs a generic lineage analysis and then go to more specific ones to identify the best lineage for the species
When the lineage is selected by the user
I tested it locally and it behaved as expected.