Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/api/users/current doesn't create new default history, anon user history panel broken #17703

Closed
mvdbeek opened this issue Mar 13, 2024 · 2 comments
Closed

/api/users/current doesn't create new default history, anon user history panel broken #17703

mvdbeek opened this issue Mar 13, 2024 · 2 comments
Assignees
@mvdbeek
Labels
area/API help wanted also "hacktoberfest", beginner friendly set of issues kind/bug
Milestone
24.0

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Mar 13, 2024

Depending on your luck and the order of requests opening usegalaxy.org as an anon user will fail because we're hitting https://github.com/mvdbeek/galaxy/blob/204cf5322ca1946b2cf762c99b02029f00f34970/lib/galaxy/webapps/galaxy/services/users.py#L127. Instead I think this is a reasonable spot to create a new default history, as we do for all legacy API routes.
@mvdbeek mvdbeek added kind/bug help wanted also "hacktoberfest", beginner friendly set of issues area/API labels Mar 13, 2024
@mvdbeek mvdbeek changed the title /api/users/current doesn't create new default history, anon user toolbox broken /api/users/current doesn't create new default history, anon user history panel broken Mar 13, 2024
@davelopez davelopez self-assigned this Mar 14, 2024
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 14, 2024

I can take this one @davelopez!

@mvdbeek mvdbeek self-assigned this Mar 14, 2024
@davelopez davelopez removed their assignment Mar 14, 2024
mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Mar 15, 2024
@mvdbeek
Add require_default_history route argument
d3e3efa 
Fixes galaxyproject#17703
@mvdbeek mvdbeek mentioned this issue Mar 15, 2024
Draft
4 tasks
@jdavcs jdavcs added this to the 24.0 milestone Mar 18, 2024
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 19, 2024

This specific issue is fixed in #17765 + #17772.

The dependency in #17755 is probably the way to go, both for default histories and sessions ... where tracking sessions isn't required we should probably not create or fetch one.

@mvdbeek mvdbeek closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvdbeek mvdbeek

Labels
area/API help wanted also "hacktoberfest", beginner friendly set of issues kind/bug
Projects
None yet
Milestone
24.0
Development

No branches or pull requests
3 participants
@jdavcs @mvdbeek @davelopez