Will galaxy.model.migrations.IncorrectVersionError not be thrown if the DB is initialized but at the wrong version?

Will galaxy.model.migrations.IncorrectVersionError not be thrown if the DB is initialized but at the wrong version?

That would be OutdatedDatabaseError. The IncorrectVersionError is only thrown here
Is my logic faulty?

Don't merge just yet - checking whether a different error may be more appropriate here (on the galaxy side).

@natefoo this should be better. Will work correctly after galaxyproject/galaxy#13695 is merged. [update: it is merged]
Essentially, the previous version was correct: that was the error that was raised when the version table was not found (as is the case with a new db). However, it was the same error as the one raised in a different context - when the db is non-empty, is under SQLAlchemy Migrate control AND is outdated (pre-180). Now it raises a more appropriate error: NoVersionTable. This is handled by code that is triggered only when scripts/manage_db.py is called directly, bypassing the shell script manage_db.sh and passing SQLAlchemy Migrate-style command arguments (version/db_version) - which is why I didn't catch this use case earlier.

@natefoo does this look OK to you?

LGTM, thanks!