Implement dry run on review modal

Author: vkulinich-cl

apps/main/.env.development

@@ -9,4 +9,4 @@ VITE_TRSRY_ADDR=7L53bUTBopuwFt3mKUfmkzgGLayYa1Yvn1hAg9v5UMrQzTfh
 VITE_EVM_CHAIN_ID=222222
 VITE_DISPLAY_ASSET_ID="10"
 VITE_HSM_ENABLED=false
-VITE_DRY_RUN_ENABLED=false
+VITE_DRY_RUN_ENABLED=true

apps/main/.env.production

@@ -9,4 +9,4 @@ VITE_TRSRY_ADDR=7L53bUTBopuwFt3mKUfmkzgGLayYa1Yvn1hAg9v5UMrQzTfh
 VITE_EVM_CHAIN_ID=222222
 VITE_DISPLAY_ASSET_ID="10"
 VITE_HSM_ENABLED=false
-VITE_DRY_RUN_ENABLED=false
+VITE_DRY_RUN_ENABLED=true

apps/main/src/api/dryRun.ts

@@ -1,41 +1,41 @@
-import { QUERY_KEY_BLOCK_PREFIX } from "@galacticcouncil/utils"
 import { queryOptions } from "@tanstack/react-query"
+import { Enum } from "polkadot-api"
 
 import { decodeTx } from "@/modules/transactions/review/ReviewTransactionJsonView/ReviewTransactionJsonView.utils"
-import { AnyPapiTx } from "@/modules/transactions/types"
+import { AnyTransaction } from "@/modules/transactions/types"
+import { isPapiTransaction } from "@/modules/transactions/utils/polkadot"
 import { getPapiTransactionCallData } from "@/modules/transactions/utils/tx"
 import { TProviderContext } from "@/providers/rpcProvider"
 
 export const papiDryRunErrorQuery = (
   { papi, dryRunErrorDecoder, papiCompatibilityToken }: TProviderContext,
   address: string,
-  tx: AnyPapiTx,
+  tx: AnyTransaction,
   debug?: boolean,
 ) =>
   queryOptions({
     queryKey: [
-      QUERY_KEY_BLOCK_PREFIX,
       "dryRun",
       "papi",
       address,
       getPapiTransactionCallData(tx, papiCompatibilityToken),
     ],
     queryFn: async () => {
       try {
-        const json = decodeTx(tx)
+        if (!isPapiTransaction(tx)) {
+          return null
+        }
+
+        const rawOrigin = Enum("Signed", address)
+        const origin = Enum("system", rawOrigin)
+
         const result = await papi.apis.DryRunApi.dry_run_call(
-          {
-            type: "system",
-            value: {
-              type: "Signed",
-              value: address,
-            },
-          },
+          origin,
           // @ts-expect-error contains structured call data
-          json,
+          tx.decodedCall,
           1,
         )
-
+        console.log(result)
         if (!result.success || result.value.execution_result.success) {
           return null
         }
@@ -44,6 +44,8 @@ export const papiDryRunErrorQuery = (
           result.value.execution_result.value.error,
         )
 
+        const json = decodeTx(tx)
+
         if (debug && error) {
           console.log(new Date().toLocaleTimeString(), error.name, json)
         }

apps/main/src/api/trade.ts

@@ -3,9 +3,7 @@ import { QUERY_KEY_BLOCK_PREFIX } from "@galacticcouncil/utils"
 import { QueryKey, queryOptions } from "@tanstack/react-query"
 import Big from "big.js"
 
-import { papiDryRunErrorQuery } from "@/api/dryRun"
 import { getTimeFrameMillis } from "@/components/TimeFrame/TimeFrame.utils"
-import { ENV } from "@/config/env"
 import {
   DcaFormValues,
   DcaOrdersMode,
@@ -84,24 +82,17 @@ export const bestSellTxQuery = (
 type BestSellWithTxArgs = BestSellArgs & {
   readonly slippage: number
   readonly address: string
-  readonly dryRun?: boolean
 }
 
 export const bestSellWithTxQuery = (
   rpc: TProviderContext,
-  { slippage, address, dryRun, ...bestSellArgs }: BestSellWithTxArgs,
+  { slippage, address, ...bestSellArgs }: BestSellWithTxArgs,
 ) => {
   const { queryClient } = rpc
   const bestSell = bestSellQuery(rpc, bestSellArgs)
 
   return queryOptions({
-    queryKey: [
-      QUERY_KEY_BLOCK_PREFIX,
-      bestSell.queryKey,
-      slippage,
-      address,
-      dryRun,
-    ],
+    queryKey: [QUERY_KEY_BLOCK_PREFIX, bestSell.queryKey, slippage, address],
     queryFn: async () => {
       const swap = await queryClient.ensureQueryData(bestSell)
 
@@ -117,17 +108,9 @@ export const bestSellWithTxQuery = (
         ? await queryClient.ensureQueryData(txQuery)
         : null
 
-      const dryRunError =
-        tx && dryRun && ENV.VITE_DRY_RUN_ENABLED
-          ? await queryClient.ensureQueryData(
-              papiDryRunErrorQuery(rpc, address, tx, bestSellArgs.debug),
-            )
-          : null
-
       return {
         swap,
         tx,
-        dryRunError,
       }
     },
     enabled: bestSell.enabled as boolean,
@@ -189,7 +172,6 @@ type BestSellTwapWithTxArgs = BestSellTwapArgs & {
   readonly slippage: number
   readonly address: string
   readonly maxRetries: number
-  readonly dryRun?: boolean
 }
 
 export const bestSellTwapWithTxQuery = (
@@ -198,7 +180,6 @@ export const bestSellTwapWithTxQuery = (
     slippage,
     maxRetries,
     address,
-    dryRun,
     ...bestSellTwapArgs
   }: BestSellTwapWithTxArgs,
   enabled = true,
@@ -213,7 +194,6 @@ export const bestSellTwapWithTxQuery = (
       slippage,
       maxRetries,
       address,
-      dryRun,
     ],
     queryFn: async () => {
       const twap = await queryClient.ensureQueryData(bestSellTwap)
@@ -231,14 +211,7 @@ export const bestSellTwapWithTxQuery = (
         ? await queryClient.ensureQueryData(txQuery)
         : null
 
-      const dryRunError =
-        tx && dryRun && ENV.VITE_DRY_RUN_ENABLED
-          ? await queryClient.ensureQueryData(
-              papiDryRunErrorQuery(rpc, address, tx),
-            )
-          : null
-
-      return { twap, tx, dryRunError }
+      return { twap, tx }
     },
     enabled: enabled && (bestSellTwap.enabled as boolean),
   })
@@ -303,24 +276,17 @@ export const bestBuyTxQuery = (
 type BestBuyWithTxArgs = BestBuyArgs & {
   readonly slippage: number
   readonly address: string
-  readonly dryRun?: boolean
 }
 
 export const bestBuyWithTxQuery = (
   rpc: TProviderContext,
-  { slippage, address, dryRun, ...bestBuyArgs }: BestBuyWithTxArgs,
+  { slippage, address, ...bestBuyArgs }: BestBuyWithTxArgs,
 ) => {
   const { queryClient } = rpc
   const bestBuy = bestBuyQuery(rpc, bestBuyArgs)
 
   return queryOptions({
-    queryKey: [
-      QUERY_KEY_BLOCK_PREFIX,
-      bestBuy.queryKey,
-      slippage,
-      address,
-      dryRun,
-    ],
+    queryKey: [QUERY_KEY_BLOCK_PREFIX, bestBuy.queryKey, slippage, address],
     queryFn: async () => {
       const swap = await queryClient.ensureQueryData(bestBuy)
 
@@ -336,17 +302,9 @@ export const bestBuyWithTxQuery = (
         ? await queryClient.ensureQueryData(txQuery)
         : null
 
-      const dryRunError =
-        tx && dryRun && ENV.VITE_DRY_RUN_ENABLED
-          ? await queryClient.ensureQueryData(
-              papiDryRunErrorQuery(rpc, address, tx, bestBuyArgs.debug),
-            )
-          : null
-
       return {
         swap,
         tx,
-        dryRunError,
       }
     },
     enabled: bestBuy.enabled as boolean,
@@ -408,18 +366,11 @@ type BestBuyTwapWithTxArgs = BestBuyTwapArgs & {
   readonly slippage: number
   readonly address: string
   readonly maxRetries: number
-  readonly dryRun?: boolean
 }
 
 export const bestBuyTwapWithTxQuery = (
   rpc: TProviderContext,
-  {
-    slippage,
-    maxRetries,
-    address,
-    dryRun,
-    ...bestBuyTwapArgs
-  }: BestBuyTwapWithTxArgs,
+  { slippage, maxRetries, address, ...bestBuyTwapArgs }: BestBuyTwapWithTxArgs,
   enabled = true,
 ) => {
   const { queryClient } = rpc
@@ -432,7 +383,6 @@ export const bestBuyTwapWithTxQuery = (
       slippage,
       maxRetries,
       address,
-      dryRun,
     ],
     queryFn: async () => {
       const twap = await queryClient.ensureQueryData(bestBuyTwap)
@@ -450,14 +400,7 @@ export const bestBuyTwapWithTxQuery = (
         ? await queryClient.ensureQueryData(txQuery)
         : null
 
-      const dryRunError =
-        tx && dryRun && ENV.VITE_DRY_RUN_ENABLED
-          ? await queryClient.ensureQueryData(
-              papiDryRunErrorQuery(rpc, address, tx),
-            )
-          : null
-
-      return { twap, tx, dryRunError }
+      return { twap, tx }
     },
     enabled: enabled && (bestBuyTwap.enabled as boolean),
   })
@@ -541,18 +484,17 @@ type DcaTradeOrderArgs = {
   readonly slippage: number
   readonly maxRetries: number
   readonly address: string
-  readonly dryRun?: boolean
 }
 
 export const dcaTradeOrderQuery = (
   rpc: TProviderContext,
-  { form, slippage, maxRetries, address, dryRun }: DcaTradeOrderArgs,
+  { form, slippage, maxRetries, address }: DcaTradeOrderArgs,
 ) => {
   const { queryClient } = rpc
   const dcaOrder = dcaOrderQuery(rpc, form)
 
   return queryOptions({
-    queryKey: [...dcaOrder.queryKey, slippage, maxRetries, address, dryRun],
+    queryKey: [...dcaOrder.queryKey, slippage, maxRetries, address],
     queryFn: async () => {
       const order = await queryClient.ensureQueryData(dcaOrder)
 
@@ -571,14 +513,7 @@ export const dcaTradeOrderQuery = (
         ? await queryClient.ensureQueryData(txQuery)
         : null
 
-      const dryRunError =
-        orderTx && dryRun && ENV.VITE_DRY_RUN_ENABLED
-          ? await queryClient.ensureQueryData(
-              papiDryRunErrorQuery(rpc, address, orderTx),
-            )
-          : null
-
-      return { order, orderTx, dryRunError }
+      return { order, orderTx }
     },
     enabled: dcaOrder.enabled as boolean,
   })

apps/main/src/api/xcm.ts

@@ -14,7 +14,7 @@ import {
 import { secondsToMilliseconds } from "date-fns"
 import { useEffect, useRef, useState } from "react"
 
-import { TProviderContext, useRpcProvider } from "@/providers/rpcProvider"
+import { useRpcProvider } from "@/providers/rpcProvider"
 
 export const useCrossChainConfig = () => {
   const { sdk } = useRpcProvider()
@@ -199,34 +199,18 @@ export const xcmTransferReportQuery = (
   })
 
 export const xcmTransferCallQuery = (
-  { dryRunErrorDecoder }: TProviderContext,
   transfer: Transfer | null,
   amount: string,
   transferArgs: XcmTransferArgs,
-  dryRun?: boolean,
 ) =>
   queryOptions({
     enabled: !!transfer && !!amount,
     placeholderData: keepPreviousData,
-    queryKey: ["xcm", "call", amount, transferArgs, dryRun],
+    queryKey: ["xcm", "call", amount, transferArgs],
     queryFn: async () => {
       if (!transfer) throw new Error("Invalid transfer")
       const call = await transfer.buildCall(amount)
 
-      const dryRunError = await (async () => {
-        if (!dryRun) {
-          return null
-        }
-
-        const result = await call?.dryRun()
-
-        if (result?.error) {
-          return await dryRunErrorDecoder.parseError(result.error)
-        }
-
-        return null
-      })()
-
-      return { call, dryRunError }
+      return { call }
     },
   })

apps/main/src/i18n/locales/en/common.json

@@ -316,6 +316,7 @@
   "transaction.alert.pendingDispatchPermit": "Permit transaction is pending. Please wait.",
   "transaction.alert.sellAll": "You are selling your entire balance of {{ value, currency }}.",
   "transaction.alert.acceptRisk": "I accept the risk involved.",
+  "transaction.alert.dryRunWarning": "Transaction might be failed. Reason: {{reason}}",
   "transaction.batch.warning": "Your transaction would exhaust block limit, we need to split it into multiple transactions",
   "transaction.batch.step.label": "Transaction {{ index }}",
   "transaction.error.unsupportedTransaction": "Unsupported transaction or signer type",

apps/main/src/modules/trade/swap/sections/DCA/Dca.tsx

@@ -32,7 +32,6 @@ export const Dca: FC = () => {
   const {
     order,
     orderTx,
-    dryRunError,
     healthFactor: initialHealthFactor,
     isLoading,
   } = useDcaTradeOrder(form)
@@ -150,11 +149,7 @@ export const Dca: FC = () => {
           }
           isLoading={isLoading}
         />
-        <DcaErrors
-          priceImpact={order?.tradeImpactPct ?? 0}
-          errors={errors}
-          dryRunError={dryRunError}
-        />
+        <DcaErrors priceImpact={order?.tradeImpactPct ?? 0} errors={errors} />
         <DcaWarnings
           isFormValid={isFormValid}
           order={order}