httpretty silently fails with Python 3.12 #474
Comments
|
@kfrydel - many thanks for this! Took me quite some time before finding this (did not appear on my G searches :D |
yarikoptic
added a commit
to yarikoptic/HTTPretty
that referenced
this issue
Nov 19, 2024
Potentially it might be addressing - gabrielfalcao#474 In our case we got datalad tests failing since we trigger errors on all new deprecation warnigns and this was the one this time .pybuild/cpython3_3.12_datalad/build/datalad/downloaders/tests/test_http.py: 13 warnings /usr/lib/python3/dist-packages/httpretty/core.py:1077: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). now = datetime.utcnow()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are switching our project to Python 3.12. We use
pytestandhttprettyin order to mock some requests. From Python 3.12datetime.utcnowis deprecated: https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnowWhen running tests using
pytest, warnings raise an exception and sincedatetime.utcnowis used by httpretty in a thread: https://github.com/gabrielfalcao/HTTPretty/blob/main/httpretty/core.py#L1077 the warning is not visible anywhere.httprettydoes not fill the file with HTTP content and tests fail with something like this:ConnectionError: Error requesting 'http://localhost:9000/path': ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')). It fails because http client gets an empty string from the file when trying to read the first line of HTTP response: https://github.com/python/cpython/blob/3.12/Lib/http/client.py#L285It can be workarounded by adding an ignore to
pytest.inifile.The text was updated successfully, but these errors were encountered: