Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CnvTranslator _from_hgvs to Hgvs Tools #392

Closed
korikuzma opened this issue Apr 10, 2024 · 2 comments
Closed

Move CnvTranslator _from_hgvs to Hgvs Tools #392

korikuzma opened this issue Apr 10, 2024 · 2 comments
Assignees
@korikuzma
Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@korikuzma
Copy link
Contributor

I think I would prefer that all the code that is related to these hgvs classes be moved to the hgvs-tools.py module. That was my aim with the prior refactoring work (which was half baked but had good intentions). Could you consider moving this (or posting a new issue for the future to refactor out the hgvs-specific logic from Translator.pyinto hgvs-tools.py?

Originally posted by @larrybabb in #387 (comment)
@korikuzma korikuzma added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Apr 10, 2024
@korikuzma korikuzma self-assigned this Apr 10, 2024
@korikuzma
Copy link
Contributor Author

This actually could've been done in #387 but I wasn't thinking properly

@korikuzma korikuzma mentioned this issue Apr 10, 2024
Merged
@korikuzma
Copy link
Contributor Author

This was done in #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@korikuzma