Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize ancillaryResults and qualityMeasures to all Study Results #250

Open
mbrush opened this issue Jan 16, 2025 · 2 comments
Open

Generalize ancillaryResults and qualityMeasures to all Study Results #250

mbrush opened this issue Jan 16, 2025 · 2 comments

Comments

@mbrush
Copy link
Contributor

mbrush commented Jan 16, 2025

Per review with @afrubin on MaveDB.

Originally posted by @ahwagner in #234 (comment)

See also Issue #144 relevant to this topic.

@mbrush
Copy link
Contributor Author

mbrush commented Jan 16, 2025

Responses from original post:

from afrubin:

This will be a very useful way to communicate relevant values like experimental variability (variance, std error) without being overly prescriptive. Having similar naming conventions/structures across GKS Study Results will also make it easier for implementers and data consumers.

From mbrush:

Agree with the utility of a way to capture this type of information in a consistent way, and agree that if we stick with this pattern as a way to capture additional data items in Study Results, then it makes sense to include them in the generic core model StudyResult class. However, reserving final judgement as I have some questions about the proposed modeling pattern, and how it relates to use and modeling of Extensions. Finally, If we do keep this pattern, I would make the simple change of renaming ancillaryReuslts to ancillaryData - as this object contains additional data items, not additional Study Results.

@mbrush
Copy link
Contributor Author

mbrush commented Jan 21, 2025

See also Issue #144 relevant to this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant