Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Contribution.date name and datatype to datetime rather than a date. #240

Open
larrybabb opened this issue Dec 5, 2024 · 1 comment

Comments

@larrybabb
Copy link
Contributor

Change Contribution.date name and datatype to datetime rather than a date.

While it might seem helpful to allow both date and datetime as permissible content types, I think it would only keep the produced data in non-compatible forms (technically speaking).

IMO, it is quite reasonable to imagine that contributions (or activities) to happen multiple times in a single day from the same agent/contributor on the same data and for the same activityType. If other's assume that to be fair, then I think it is best to allow for the more specfic (or precise) datetime representation. Those that only use the date portion can use the very common practice of defaulting 00:00:000 for the time portion and commuicating that decision to downstream users of their data.


Vote up or down if you agree with changing the attribute Contribution.date to Contribution.datetime and changing the associated datatype to the gks-core primitive datatype from date to datetime.

Originally posted by @larrybabb in #234 (comment)

@mbrush
Copy link
Contributor

mbrush commented Dec 20, 2024

I agree with changing the data type. but not keen on so strictly tying attribute names to a technical data type. I think it is fine to keep date as the attribute name - and use a dateTime data type that allows time of day if desired. But I suspect just the date will be sufficient in most cases. Don’t feel super strongly however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants