Skip to content

Commit ed44db2

Browse files
committed
minor comment fixes
1 parent 7cf78fb commit ed44db2

File tree

8 files changed

+12
-12
lines changed

8 files changed

+12
-12
lines changed

schema/gks-core/gks-core-source.yaml

+5-5
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ $defs:
1818
unique within a given system, but may or may not be globally unique outside the system. It
1919
is used within a system to reference an object from another.
2020
$comment: >-
21-
Note that it is core for implementers to create their own internal logical ids -
21+
Note that it is common for implementers to create their own internal logical ids -
2222
typically a serially or randomly generated value like a UUID that is assigned to the
2323
data object as it is created in a system. But an implementer may choose to re-use an
2424
existing, globally unique id from an external system or authority for this purpose
@@ -514,13 +514,13 @@ $defs:
514514
# Statement profile. e.g. in the VariantPathogenicityStatement profile, it is specialized into
515515
# 'modeOfInheritanceQualifier' and 'geneContextQualifier' attributes.
516516
# We are commenting out this property for now to avoid its unwanted inheritance in Statement profiles
517-
# that import the core-im. We will re-instate this property once we determine how the modeling framework
517+
# that import the gks-core. We will re-instate this property once we determine how the modeling framework
518518
# and tools can support formal specification of the conceptual specialization that is happening here.
519519
#
520520
# qualifier:
521521
# type: object
522522
# description: >-
523-
# An additional piece of information that extends or refines the meaning of the a Statement's core
523+
# An additional piece of information that extends or refines the meaning of the a Statement's common
524524
# subject-predicate-object 'triple' - by providing additional details, precision, or constraining
525525
# the statement to apply in a particular context.
526526
# $comment: >-
@@ -595,7 +595,7 @@ $defs:
595595
semantics that uses the subject-predicate-object-qualifier pattern.
596596
597597
# Note that the `proposition` property below is a proposed addition to the Statement class that is not yet
598-
# implemented in the core IM, but included as below to illustrate a possible alternative modeling pattern.
598+
# implemented in the Core IM, but included as below to illustrate a possible alternative modeling pattern.
599599
#
600600
# proposition:
601601
# $ref: "#/$defs/Proposition"
@@ -738,7 +738,7 @@ $defs:
738738
# For example, in the the CohortAlleleFrequencyStudyResult profile, it is specialized into 'focusAlleleCount',
739739
# 'focusAlleleFrequency', and 'locuslAlleleCount' attributes.
740740
# We are commenting out this property for now to avoid its unwanted inheritance in StudyResult profiles
741-
# that import the core-im. We will re-instate this property once we determine how the modeling framework
741+
# that import the gks-core. We will re-instate this property once we determine how the modeling framework
742742
# and tools can support formal specificaiton of the conceptual specialization that is happening here.
743743
#
744744
# dataItem:

schema/gks-core/json/Agent

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"id": {
1010
"type": "string",
1111
"description": "The 'logical' identifier of the Entity in the system of record, e.g. a UUID. This 'id' is unique within a given system, but may or may not be globally unique outside the system. It is used within a system to reference an object from another.",
12-
"$comment": "Note that it is core for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
12+
"$comment": "Note that it is common for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
1313
},
1414
"label": {
1515
"type": "string",

schema/gks-core/json/Contribution

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"id": {
1010
"type": "string",
1111
"description": "The 'logical' identifier of the Entity in the system of record, e.g. a UUID. This 'id' is unique within a given system, but may or may not be globally unique outside the system. It is used within a system to reference an object from another.",
12-
"$comment": "Note that it is core for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
12+
"$comment": "Note that it is common for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
1313
},
1414
"label": {
1515
"type": "string",

schema/gks-core/json/DataSet

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"id": {
1111
"type": "string",
1212
"description": "The 'logical' identifier of the Entity in the system of record, e.g. a UUID. This 'id' is unique within a given system, but may or may not be globally unique outside the system. It is used within a system to reference an object from another.",
13-
"$comment": "Note that it is core for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
13+
"$comment": "Note that it is common for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
1414
},
1515
"label": {
1616
"type": "string",

schema/gks-core/json/Document

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"id": {
1111
"type": "string",
1212
"description": "The 'logical' identifier of the Entity in the system of record, e.g. a UUID. This 'id' is unique within a given system, but may or may not be globally unique outside the system. It is used within a system to reference an object from another.",
13-
"$comment": "Note that it is core for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
13+
"$comment": "Note that it is common for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
1414
},
1515
"label": {
1616
"type": "string",

schema/gks-core/json/EvidenceLine

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"id": {
1111
"type": "string",
1212
"description": "The 'logical' identifier of the Entity in the system of record, e.g. a UUID. This 'id' is unique within a given system, but may or may not be globally unique outside the system. It is used within a system to reference an object from another.",
13-
"$comment": "Note that it is core for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
13+
"$comment": "Note that it is common for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
1414
},
1515
"label": {
1616
"type": "string",

schema/gks-core/json/Method

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"id": {
1111
"type": "string",
1212
"description": "The 'logical' identifier of the Entity in the system of record, e.g. a UUID. This 'id' is unique within a given system, but may or may not be globally unique outside the system. It is used within a system to reference an object from another.",
13-
"$comment": "Note that it is core for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
13+
"$comment": "Note that it is common for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
1414
},
1515
"label": {
1616
"type": "string",

schema/gks-core/json/StudyGroup

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"id": {
1111
"type": "string",
1212
"description": "The 'logical' identifier of the Entity in the system of record, e.g. a UUID. This 'id' is unique within a given system, but may or may not be globally unique outside the system. It is used within a system to reference an object from another.",
13-
"$comment": "Note that it is core for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
13+
"$comment": "Note that it is common for implementers to create their own internal logical ids - typically a serially or randomly generated value like a UUID that is assigned to the data object as it is created in a system. But an implementer may choose to re-use an existing, globally unique id from an external system or authority for this purpose (e.g. an HGNC id for a Gene object) - as long as it is unique within the implementing system, and can be used to reference the identified object in this context."
1414
},
1515
"label": {
1616
"type": "string",

0 commit comments

Comments
 (0)