Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifiers as filters #188

Open
mbaudis opened this issue Nov 19, 2024 · 0 comments
Open

Identifiers as filters #188

mbaudis opened this issue Nov 19, 2024 · 0 comments

Comments

@mbaudis
Copy link
Member

mbaudis commented Nov 19, 2024

A filter sent to a beacon as part of the request is defined as

    anyOf:
      - $ref: '#/$defs/OntologyFilter'
      - $ref: '#/$defs/AlphanumericFilter'
      - $ref: '#/$defs/CustomFilter'  

... where an OntologyFilter has the description to Filter results to include records that contain a specific ontology term.; and the OntologyFilter.id is the Term ID to be queried, using CURIE syntax where possible..

However, this leaves the problem of stable identifiers which are not part of ontologies on the "classical sense" but essential for many types of queries and fulfill the CURIE part with registration at identifiers.org et al. Examples:

  • pubmed:35297548
  • cellosaurus:CVCL_0030 (cell line identifiers - have actually a hierarchy...)

Action Item

  • Option A: Extend the definition of OntologyFilter to ... ontology term or identifier - easy and implementers do it like that anyway
  • Option B: Define a dedicated '#/$defs/IdentifierFilter' ... which follows the OntologyFilter definition (I guess minus "similarity")

In practice both options would be non-breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant