Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding field_type breaks default.form #36

Open
sergei-maertens opened this issue Jan 27, 2015 · 3 comments
Open

Adding field_type breaks default.form #36

sergei-maertens opened this issue Jan 27, 2015 · 3 comments

Comments

@sergei-maertens
Copy link
Contributor

In version 1.0.12 field_type was added to the fields variables available in the template. This breaks the *input widgets, as before this value was empty and caught by the 'default' filter (in case of a TextInput).

The html now shows

<input type="CharField">

I suggest renaming 'field_type' in default.form to 'input_type'.
@funkybob
Copy link
Owner

Brain fart... have changed this to field_class.

funkybob added a commit that referenced this issue Feb 15, 2015
@funkybob
Rename field_type to field_class to avoid breaking templates [Fixes: #36
dfaad55 
]
@sergei-maertens
Copy link
Contributor Author

Cool, thanks! I'll wait for the version bump and PyPI upload.

@julianwachholz
Copy link
Contributor

And I specifically renamed my field_type to input_type :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@funkybob @julianwachholz @sergei-maertens