use wxString instead of std::string

Author: fungaren

CMakeLists.txt

@@ -8,15 +8,19 @@ if (UNIX)
     set(CMAKE_CXX_STANDARD 11)
     set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
-    # set build type and flags
+    # set(CMAKE_CXX_COMPILER clang++)
+    # string(CONCAT CMAKE_CXX_FLAGS
+    #     "-stdlib=libstdc++ " # Do not use libc++ as wxWidgets libraries are precompiled
+    # )
+
+    # Set build type and flags
     string(CONCAT CMAKE_CXX_FLAGS_DEBUG
-        "-Wall "            # display all warnings
-        "-g "               # with debug information
-        "-O0 "               # no optimize
-        "-Wno-parentheses"   # disable parentheses warning
+        "-Wall "            # Display all warnings
+        "-g "               # With debug information
+        "-O0 "              # No optimize
     )
     string(CONCAT CMAKE_CXX_FLAGS_RELEASE
-        "-O3"               # enable optimize
+        "-O3 "               # Enable optimize
     )
     if (CMAKE_BUILD_TYPE STREQUAL "")
         set(CMAKE_BUILD_TYPE "Release")
@@ -44,31 +48,38 @@ if (UNIX)
         "${PROJECT_SOURCE_DIR}/static/mynotepad.desktop.in"
         "${PROJECT_SOURCE_DIR}/static/mynotepad.desktop"
     )
+
+    # find_package(PkgConfig REQUIRED)
+    # pkg_check_modules(GTK gtk+-3.0 REQUIRED)
+    # include_directories(${GTK_INCLUDE_DIRS})
+    # message(STATUS "GTK headers: ${GTK_INCLUDE_DIRS}")
+    # message(STATUS "GTK libraries: ${GTK_LIBRARIES}")
+    # set(EXTRA_LIBS ${EXTRA_LIBS} ${GTK_LIBRARIES})
 endif()
 
-# specify the path manually
+# Specify the path manually
 if (WIN32)
     #set(wxWidgets_ROOT_DIR "D:/wxWidgets-3.1.3/")
     #set(wxWidgets_LIB_DIR "D:/wxWidgets-3.1.3/lib/vc14x_dll")
 endif()
 set(wxWidgets_CONFIGURATION mswu) # or mswud
 
-# find wxWidgets
+# Find wxWidgets
 find_package(wxWidgets COMPONENTS core base stc REQUIRED)
 message(STATUS "wxWidgets version: ${wxWidgets_VERSION_MAJOR}."
         "${wxWidgets_VERSION_MINOR}.${wxWidgets_VERSION_PATCH}")
 
 include(${wxWidgets_USE_FILE})
 set(EXTRA_LIBS ${EXTRA_LIBS} ${wxWidgets_LIBRARIES})
 
-# define header directory
+# Define header directory
 include_directories(
     "${PROJECT_BINARY_DIR}/inc"
     "${PROJECT_SOURCE_DIR}/inc"
     "${PROJECT_SOURCE_DIR}/static"
     "${PROJECT_SOURCE_DIR}/md2html/inc"
 )
-# define source directory
+# Define source directory
 aux_source_directory(src SOURCES)
 
 if (WIN32)
@@ -77,7 +88,7 @@ if (WIN32)
     list(APPEND SOURCES "static/mynotepad.manifest")
 endif()
 
-# target executable file
+# Target executable file
 set(TARGET mynotepad)
 add_executable(${TARGET} WIN32 ${SOURCES})
 
@@ -101,12 +112,12 @@ else()
     set(EXTRA_LIBS ${EXTRA_LIBS} md2html)
 endif()
 
-# link libraries
+# Link libraries
 target_link_libraries(${TARGET} ${EXTRA_LIBS})
 
 if (WIN32)
     set(WXVER "${wxWidgets_VERSION_MAJOR}${wxWidgets_VERSION_MINOR}${wxWidgets_VERSION_PATCH}")
-    # required DLLs on Windows
+    # Required DLLs on Windows
     set(ALL_DLLS_DEBUG
         "${wxWidgets_LIB_DIR}/wxbase${WXVER}ud_vc14x_x64.dll"
         "${wxWidgets_LIB_DIR}/wxbase${WXVER}ud_net_vc14x_x64.dll"
@@ -130,7 +141,7 @@ if (WIN32)
         "${PROJECT_SOURCE_DIR}/static/logo.png"
         "${PROJECT_SOURCE_DIR}/static/mynotepad.visualelementsmanifest.xml"
         )
-    # destination directory
+    # Destination directory
     set(COPY_DLLS_TO ${PROJECT_BINARY_DIR}/)
     #message(STATUS ${COPY_DLLS_TO})
     add_custom_command(TARGET ${TARGET} POST_BUILD
@@ -141,21 +152,21 @@ if (WIN32)
         )
 
 elseif (UNIX)
-    # default path is /usr/local/
+    # Default path is /usr/local/
     message(STATUS "CMAKE_INSTALL_PREFIX: ${CMAKE_INSTALL_PREFIX}")
 
-    # install the program after build, /usr/local/bin/
+    # Install the program after build, /usr/local/bin/
     install(TARGETS ${TARGET} RUNTIME DESTINATION bin)
-    
-    # copy dependent files while installing, default path is /usr/local/share
+
+    # Copy dependent files while installing, default path is /usr/local/share
     install(DIRECTORY "${PROJECT_SOURCE_DIR}/static/"
             DESTINATION "share/${PROJECT_NAME}"
             # make the files writable
             FILE_PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ GROUP_WRITE WORLD_READ WORLD_WRITE
             FILES_MATCHING PATTERN "*.css" PATTERN "*.js" PATTERN "*.png"
             )
-    
-    # create desktop icon
+
+    # Create desktop icon
     install(FILES "${PROJECT_SOURCE_DIR}/static/mynotepad.desktop"
             DESTINATION /usr/share/applications
             PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ

README.md

@@ -6,7 +6,7 @@
 
 A markdown editor that supports exporting HTML.
 
-This program is initially written in pure win32 APIs just like [this](https://msdn.microsoft.com/en-us/library/windows/desktop/ms646268(v=vs.85).aspx). Later it's rewritten using wxWidgets, you can build it in Windows and Linux. 
+This program is initially written in pure win32 APIs just like [this](https://msdn.microsoft.com/en-us/library/windows/desktop/ms646268(v=vs.85).aspx). Later it's rewritten using wxWidgets, you can build it in Windows and Linux.
 
 Download binaries: [Release](../../releases)
 
@@ -18,10 +18,15 @@ Try this markdown file: [test.md](test.md)
 
 ```bash
 sudo apt update
-sudo apt install build-essential cmake libwxgtk3.0-dev
+sudo apt install build-essential cmake git
+# Debian 9
+sudo apt install libwxgtk3.0-dev
+# Debian 10
+sudo apt install libwxgtk3.0-gtk3-dev
 git clone https://github.com/mooction/mynotepad
-cd mynotepad
-cmake .
+mkdir mynotepad/build
+cd mynotepad/build
+cmake .. -DCMAKE_BUILD_TYPE=Release
 make
 sudo make install
 ```
@@ -64,7 +69,7 @@ See [CMakeLists.txt](CMakeLists.txt) for more detail.
 
 5. Set `wxWidgets_ROOT_DIR` and `wxWidgets_LIB_DIR` to the wxWidgets library folder. For the instance above, set `wxWidgets_ROOT_DIR` to `D:\wxWidgets-3.1.3\` and set `wxWidgets_LIB_DIR` to `D:\wxWidgets-3.1.3\lib\vc14x_x64_dll`.
 
-6. Click `Configure` again, then click `Generate`, finally we get a Visual Studio solution. 
+6. Click `Configure` again, then click `Generate`, finally we get a Visual Studio solution.
 
 ### Options
 
@@ -74,15 +79,14 @@ Use `cmake -D<VAR>=<VALUE>` to change any option.
 | - | - | - |
 | `CMAKE_BUILD_TYPE` | Debug | Build Type for Unix (Release / Debug) |
 
-## Known bugs
+## Known issue
 
-1. (Linux)Texts copied to clipboard will disappear after the window closed
-2. (Linux)Fail to open/save file in non-ascii path 
+1. (Linux) Copied text will disappear after the window closed
 
 ## TODO
 
-- search & replace
-- encode conversion(only support utf-8 currently)
+- Search & replace
+- Encode conversion (only support utf-8 currently)
 
 ## Programming Guide
 

inc/main.h

@@ -1,39 +1,39 @@
 #ifndef __MAIN_H__
 #define __MAIN_H__
 
-const char*  MNP_APPNAME               = "MyNotePad";
-const char*  MNP_DOC_TITLE             = " - MyNotePad";
-const char*  MNP_DOC_NOTITLE           = "Untitled";
-const char*  MNP_COPYRIGHT             = "\nCopyright(c) moooc.cc";
+const wxChar* MNP_APPNAME        = wxS("MyNotePad");
+const wxChar* MNP_DOC_TITLE      = wxS(" - MyNotePad");
+const wxChar* MNP_DOC_NOTITLE    = wxS("Untitled");
+const wxChar* MNP_COPYRIGHT      = wxS("\nCopyright(c) moooc.cc");
 
-int          MNP_PADDING_LEFT          = 16;    // space for line number
-const int    MNP_LINENUM_MARGIN_LEFT   = 4;
-const int    MNP_LINENUM_MARGIN_TOP    = 4;
-const char*  MNP_LINENUM_FONTFACE      = "Arial";
-const int    MNP_SCROLLBAR_WIDTH       = 14;
+int          MNP_PADDING_LEFT           = 16;   // space for line number
+const int    MNP_LINENUM_MARGIN_LEFT    = 4;
+const int    MNP_LINENUM_MARGIN_TOP     = 4;
+const int    MNP_SCROLLBAR_WIDTH        = 14;
+const wxChar* MNP_LINENUM_FONTFACE      = wxS("Arial");
 
-const char*  MNP_CONFIG_FILE           = "MyNotePad.conf";
-const char*  MNP_CONFIG_THEME          = "theme";
-const char*  MNP_CONFIG_WORDWRAP       = "word-wrap";
-const char*  MNP_CONFIG_LINENUMBER     = "line-number";
-const char*  MNP_CONFIG_FONTNAME       = "font-name";
+const wxChar* MNP_CONFIG_FILE           = wxS("MyNotePad.conf");
+const wxChar* MNP_CONFIG_THEME          = wxS("theme");
+const wxChar* MNP_CONFIG_WORDWRAP       = wxS("word-wrap");
+const wxChar* MNP_CONFIG_LINENUMBER     = wxS("line-number");
+const wxChar* MNP_CONFIG_FONTNAME       = wxS("font-name");
 
-const char*  INFO_SAVE                 = "Save changes?";
-const char*  ERR_OPEN_FAIL             = "Failed to save HTML file, \n"\
-                                         "make sure you have permissions to write that file.";
-const char*  ERR_FAULT_ENCODING        = "Can only open UTF-8 files!";
-const char*  ERR_UNKNOWN               = "Unknown error";
+const wxChar* INFO_SAVE          = wxS("Save changes?");
+const wxChar* ERR_OPEN_FAIL      = wxS("Failed to save HTML file, \n"\
+                                         "make sure you have permissions to write that file.");
+const wxChar* ERR_FAULT_ENCODING = wxS("Can only open UTF-8 files!");
+const wxChar* ERR_UNKNOWN        = wxS("Unknown error");
 
 #ifdef _WIN32
-const char*  FONT_1     = "Microsoft Yahei";
-const char*  FONT_2     = "Lucida Console";
-const char*  FONT_3     = "Courier New";
-const char*  FONT_4     = "Consolas";
+const wxChar* FONT_1     = wxS("Microsoft Yahei");
+const wxChar* FONT_2     = wxS("Lucida Console");
+const wxChar* FONT_3     = wxS("Courier New");
+const wxChar* FONT_4     = wxS("Consolas");
 #else
-const char*  FONT_1     = "Noto Sans Mono";
-const char*  FONT_2     = "Liberation Mono";
-const char*  FONT_3     = "Courier 10 Pitch";
-const char*  FONT_4     = "DejaVu Sans Mono";
+const wxChar* FONT_1     = wxS("Noto Sans Mono");
+const wxChar* FONT_2     = wxS("Liberation Mono");
+const wxChar* FONT_3     = wxS("Courier 10 Pitch");
+const wxChar* FONT_4     = wxS("DejaVu Sans Mono");
 #endif
 
 struct CharStyle
@@ -49,18 +49,17 @@ const CharStyle default_style = { 0 };
 class MyFrame : public wxFrame {
 public:
     MyFrame(const wxString& title);
-    
+
     void themeLight();
     void themeDark();
     void loadSettings();
     void saveSettings();
     void updateSaveState(bool saved);
-    void loadFile(const std::string path);
+    void loadFile(wxString path);
     bool sureToQuit(wxCommandEvent& event);
-    void saveHTML(const std::string pathname);
-    std::string all_to_string();
+    void saveHTML(const wxString& pathname);
     void ApplyTheme();
-    void md2html(std::string& str);
+    void md2html(wxString& str);
     int widthOfLineNumber() const;
 #ifndef _WIN32
     // this function is not exists on Linux
@@ -76,14 +75,14 @@ class MyFrame : public wxFrame {
     void OnRightButtonUp(wxMouseEvent& event);
     void OnKeyDown(wxKeyEvent& event);
     void OnChar(wxKeyEvent& event);
-    
+
     void OnNew(wxCommandEvent& event);
     void OnOpen(wxCommandEvent& event);
     void OnSave(wxCommandEvent& event);
     void OnSaveAs(wxCommandEvent& event);
     void OnCopyHtml(wxCommandEvent& event);
     void OnExportHTML(wxCommandEvent& event);
-    void OnQuit(wxCommandEvent& event);
+    void OnMenuClose(wxCommandEvent& event);
     void OnUndo(wxCommandEvent& event);
     void OnRedo(wxCommandEvent& event);
     void OnCut(wxCommandEvent& event);
@@ -116,10 +115,9 @@ class MyFrame : public wxFrame {
     };
     notepadCtrl *article;
     bool bShowLineNumber;       // display line number (initial true)
-    bool bResized;              // flag indicates the app window is resized
     bool bSaved;                // set false after file is modified
     bool bWordWrap;             // break word (initial false)
-    
+
     enum THEME {
         THEME_LIGHT,
         THEME_DARK
@@ -135,12 +133,12 @@ class MyFrame : public wxFrame {
     wxColour lineNumFontColor;
     wxColour scrollBarBgColor;
     wxColour scrollBarColor;
-    const char* fontFace;
     int fontSize;
     int lineNumFontSize;
+    const wxChar* fontFace;
     // configure file Path
-    std::string confFilePath;
-    std::string openedFile;
+    wxString confFilePath;
+    wxString openedFile;
     DECLARE_EVENT_TABLE()
 };