fix(#1300): add explicit trigger_source mapping to fix agent#1308
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#1300): add explicit trigger_source mapping to fix agent#1308fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The fix agent's TRIGGER_SOURCE env var contains a GitHub username (e.g. "orgname-review[bot]" or "alice"), but the fix-result.json schema requires trigger_source to be the enum "bot" or "human". The skill and agent definition never explicitly instructed the agent to map the username to the enum value, so the LLM would copy the raw username into the JSON — causing schema validation to reject the output (5 of 8 recent failures). Changes: - agents/fix.md: add explicit mapping instruction in the trigger modes section — if username ends in [bot] use "bot", else "human" - skills/fix-review/SKILL.md step 1: instruct the agent to derive the normalized trigger type early - skills/fix-review/SKILL.md step 9: add schema compliance section covering additionalProperties: false, the trigger_source enum constraint, and per-action-type required fields (description for fix, reason for disagree) Note: make lint could not run in sandbox (Go toolchain permission denied). Pre-existing infrastructure issue unrelated to this change. Closes #1300 Signed-off-by: fullsend-code <[email protected]>
Site previewPreview: https://de731e5e-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix agent's TRIGGER_SOURCE env var contains a GitHub username (e.g. "orgname-review[bot]" or "alice"), but the fix-result.json schema requires trigger_source to be the enum "bot" or "human". The skill and agent definition never explicitly instructed the agent to map the username to the enum value, so the LLM would copy the raw username into the JSON — causing schema validation to reject the output (5 of 8 recent failures).
Changes:
modes section — if username ends in [bot] use "bot", else
"human"
derive the normalized trigger type early
section covering additionalProperties: false, the
trigger_source enum constraint, and per-action-type required
fields (description for fix, reason for disagree)
Note: make lint could not run in sandbox (Go toolchain permission denied). Pre-existing infrastructure issue unrelated to this change.
Closes #1300
Post-script verification
agent/1300-fix-agent-schema-validation)33244271743c5a6ab9af8038f2bd69e8d1610ab7..HEAD)