fix(#1236): show exec error when validation script fails to run#1238
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#1236): show exec error when validation script fails to run#1238fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
When a validation script cannot be executed (e.g., ENOENT or EACCES), CombinedOutput() returns empty output with a non-nil error. Previously the failure message used only the (empty) output, producing a blank "Validation failed:" message. Now falls back to the exec error string when output is empty, giving operators the actual diagnostic. Closes #1236 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Site previewPreview: https://5b84783e-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a validation script cannot be executed (e.g., ENOENT or EACCES), CombinedOutput() returns empty output with a non-nil error. Previously the failure message used only the (empty) output, producing a blank "Validation failed:" message. Now falls back to the exec error string when output is empty, giving operators the actual diagnostic.
Co-Authored-By: Claude Opus 4.6 [email protected]
Closes #1236
Post-script verification
fullsend/code/issue-1236)7813c92add42ca3ba723cf83de489fd6a67d442a..HEAD)