Skip to content

fix(#1220): add fix role to PerRepoDefaultRoles for dispatch loop #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −1
Open

fix(#1220): add fix role to PerRepoDefaultRoles for dispatch loop #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c11b838
fix: add fix role to PerRepoDefaultRoles for review→fix dispatch loop
May 19, 2026
2991723
test: add TestPerRepoDefaultRoles for regression coverage
May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func DefaultAgentRoles() []string {
// The "fullsend" dispatch role is excluded because per-repo mode uses
// the target repo's shim workflow for dispatch instead of a separate app.
func PerRepoDefaultRoles() []string {
return []string{"triage", "coder", "review", "retro", "prioritize"}
return []string{"triage", "coder", "review", "fix", "retro", "prioritize"}
}

// NewOrgConfig creates a new OrgConfig with sensible defaults.
Expand Down
13 changes: 13 additions & 0 deletions internal/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,19 @@ func TestValidRoles(t *testing.T) {
assert.Contains(t, roles, "prioritize")
}

func TestPerRepoDefaultRoles(t *testing.T) {
roles := PerRepoDefaultRoles()
assert.Len(t, roles, 6)
assert.Contains(t, roles, "triage")
assert.Contains(t, roles, "coder")
assert.Contains(t, roles, "review")
assert.Contains(t, roles, "fix")
assert.Contains(t, roles, "retro")
assert.Contains(t, roles, "prioritize")
// "fullsend" dispatch role must be excluded in per-repo mode.
assert.NotContains(t, roles, "fullsend")
}

func TestNewOrgConfig(t *testing.T) {
allRepos := []string{"repo-a", "repo-b", "repo-c"}
enabledRepos := []string{"repo-a", "repo-c"}
Expand Down
Loading