Skip to content

fix(#1220): add fix role to PerRepoDefaultRoles for dispatch loop#1225

Open
fullsend-ai-coder[bot] wants to merge 2 commits into
mainfrom
fullsend/code/issue-1220
Open

fix(#1220): add fix role to PerRepoDefaultRoles for dispatch loop#1225
fullsend-ai-coder[bot] wants to merge 2 commits into
mainfrom
fullsend/code/issue-1220

Conversation

@fullsend-ai-coder
Copy link
Copy Markdown

The fix role was missing from PerRepoDefaultRoles(), causing the dispatch role-check to block fix agent runs after review requested changes. All other agent roles were already included. The fix role has full agent scaffolding and is ready for production use.

Co-Authored-By: Claude Opus 4.6 [email protected]


Closes #1220

Post-script verification

  • Branch is not main/master (fullsend/code/issue-1220)
  • Secret scan passed (gitleaks — ece4b4b71a4d2eb5563ac365f04a333b95722288..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

The fix role was missing from PerRepoDefaultRoles(), causing the
dispatch role-check to block fix agent runs after review requested
changes. All other agent roles were already included. The fix role
has full agent scaffolding and is ready for production use.

Closes #1220

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Site preview

Preview: https://52b5920e-site.fullsend-ai.workers.dev

Commit: 2991723a42133836ae8f73cfde9691b91539be62

@fullsend-ai-review
Copy link
Copy Markdown

fullsend-ai-review Bot commented May 19, 2026

Review

Findings

No findings.

Previous run

Review

Findings

Low

  • [test-coverage] internal/config/config_test.go — No dedicated test for PerRepoDefaultRoles(). Other role functions (ValidRoles, DefaultAgentRoles) have explicit tests, but PerRepoDefaultRoles() lacks one. The linked issue's triage comment proposed a test; adding one would prevent future regressions where a role is accidentally omitted again.
    Remediation: Add a TestPerRepoDefaultRolesIncludesFix test (or a broader test asserting all expected roles are present), similar to the pattern in TestValidRoles.

@fullsend-ai-review
Copy link
Copy Markdown

Review follow-ups

Created follow-up issues for actionable non-blocking review findings:

  • #1226 — No dedicated test for PerRepoDefaultRoles(). Other role functions (ValidRoles, DefaultAgentRoles) have explicit tests, but PerRepoDefaultRoles() lacks one. Adding a test would prevent future regressions where a role is accidentally omitted.

@rh-hemartin
Copy link
Copy Markdown
Contributor

/fs-fix

@rh-hemartin rh-hemartin self-assigned this May 20, 2026
@rh-hemartin rh-hemartin changed the title fix(#1220): add fix role to PerRepoDefaultRoles for review→fix dispatch loop fix(#1220): add fix role to PerRepoDefaultRoles for dispatch loop May 20, 2026
@rh-hemartin
Copy link
Copy Markdown
Contributor

/fs-fix

Adds a dedicated test for PerRepoDefaultRoles() to verify all expected
roles are present and that the "fullsend" dispatch role is excluded in
per-repo mode. Prevents future regressions where a role is accidentally
omitted.

Addresses review feedback on #1225

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: fullsend-fix <[email protected]>
@fullsend-ai-coder
Copy link
Copy Markdown
Author

🔧 Fix agent — iteration 1 (human-triggered)

Addressed 1 review finding: added TestPerRepoDefaultRoles test for regression coverage of the PerRepoDefaultRoles() function.

Fixed (1):

  1. No dedicated test for PerRepoDefaultRoles() (internal/config/config_test.go): Added TestPerRepoDefaultRoles test that verifies all 6 expected roles are present (triage, coder, review, fix, retro, prioritize) and that the fullsend dispatch role is excluded in per-repo mode. Follows the same pattern as TestValidRoles.

Tests: passed

Updated by fullsend fix agent

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fix role to PerRepoDefaultRoles so review→fix loop works by default

1 participant