fix(#1220): add fix role to PerRepoDefaultRoles for dispatch loop#1225
Open
fullsend-ai-coder[bot] wants to merge 2 commits into
Open
fix(#1220): add fix role to PerRepoDefaultRoles for dispatch loop#1225fullsend-ai-coder[bot] wants to merge 2 commits into
fullsend-ai-coder[bot] wants to merge 2 commits into
Conversation
The fix role was missing from PerRepoDefaultRoles(), causing the dispatch role-check to block fix agent runs after review requested changes. All other agent roles were already included. The fix role has full agent scaffolding and is ready for production use. Closes #1220 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Site previewPreview: https://52b5920e-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Previous runReviewFindingsLow
|
Review follow-upsCreated follow-up issues for actionable non-blocking review findings:
|
Contributor
|
/fs-fix |
rh-hemartin
approved these changes
May 20, 2026
Contributor
|
/fs-fix |
Adds a dedicated test for PerRepoDefaultRoles() to verify all expected roles are present and that the "fullsend" dispatch role is excluded in per-repo mode. Prevents future regressions where a role is accidentally omitted. Addresses review feedback on #1225 Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: fullsend-fix <[email protected]>
Author
🔧 Fix agent — iteration 1 (human-triggered)Addressed 1 review finding: added TestPerRepoDefaultRoles test for regression coverage of the PerRepoDefaultRoles() function. Fixed (1):
Tests: passed Updated by fullsend fix agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix role was missing from PerRepoDefaultRoles(), causing the dispatch role-check to block fix agent runs after review requested changes. All other agent roles were already included. The fix role has full agent scaffolding and is ready for production use.
Co-Authored-By: Claude Opus 4.6 [email protected]
Closes #1220
Post-script verification
fullsend/code/issue-1220)ece4b4b71a4d2eb5563ac365f04a333b95722288..HEAD)