fix(hack): report broken symlinks before exiting#1152
Open
rh-hemartin wants to merge 1 commit into
Open
Conversation
Site previewPreview: https://9ec0fd59-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Previous runReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
set -e caused silent exit when a tracked path had mode 120000 but was not a symlink on disk — readlink aborted the script before the report block ran. Guard with [[ -L ]] so non-symlink paths get an explicit message, tolerate readlink failures, and add ERR trap for any other unexpected abort. Closes #1106
rh-hemartin
force-pushed
the
fix/lint-broken-symlinks-silent-failure
branch
from
1fed79d to
e5a7068
Compare
fullsend-ai-review
Bot
added
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -ecaused silent exit when a tracked path had mode120000but wasn't a symlink on disk —readlinkaborted before the report block ran[[ -L ]]so non-symlink tracked paths get an explicit messagereadlinkfailures with|| echo "<unreadable>"ERRtrap so any unexpected abort still prints line numberReproducer
Test plan
bash hack/lint-broken-symlinkspasses on clean repoCloses #1106