-
Notifications
You must be signed in to change notification settings - Fork 41
Add style to allowed commit-lint prefixes #1529
Copy link
Copy link
Open
Labels
component/ciCI pipelines and checksCI pipelines and checksgood-fullsend-issueSuitable for fullsend to tackle autonomously once self-hostedSuitable for fullsend to tackle autonomously once self-hostedpriority/mediumNormal priority, plan for next cycleNormal priority, plan for next cycleready-to-codeTriaged and ready for the code agentTriaged and ready for the code agenttype/choreMaintenance and housekeeping tasksMaintenance and housekeeping tasks
Metadata
Metadata
Assignees
Labels
component/ciCI pipelines and checksCI pipelines and checksgood-fullsend-issueSuitable for fullsend to tackle autonomously once self-hostedSuitable for fullsend to tackle autonomously once self-hostedpriority/mediumNormal priority, plan for next cycleNormal priority, plan for next cycleready-to-codeTriaged and ready for the code agentTriaged and ready for the code agenttype/choreMaintenance and housekeeping tasksMaintenance and housekeeping tasks
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
Todo
What happened
PR #1178 included commit
2a0be48with messagestyle: ruff-format unicode_posttool.py. The merge queue CI run (26467180105) failed because the.gitlintCT1 rule only allowsfeat, fix, refactor, docs, test, chore, ci, perf— notstyle. The PR was ultimately merged directly by waynesun09, bypassing the failed merge queue check.What could go better
The
styleprefix is part of the Conventional Commits spec and is commonly used for formatting-only changes (exactly what happened here — running ruff-format). The repo's CLAUDE.md and CONTRIBUTING.md reference Conventional Commits, but the gitlint config is stricter than the spec. This creates a gap where valid conventional commits fail CI. High confidence this is a real issue — the evidence is direct (CI failure log shows the exact rule violation).Proposed change
Update
.gitlint(or equivalent commit-lint config) to addstyleto the CT1 allowed prefixes list. Also consider addingbuildandrevertwhich are other standard Conventional Commits types that may be missing. The full standard set is:feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert.Validation criteria
After the change,
style:prefixed commits should pass the commit-lint CI job. Verify by checking that the next merge queue run with astyle:commit does not fail on CT1.Generated by retro agent from #1178