Skip to content

Add style to allowed commit-lint prefixes #1529

@fullsend-ai-retro

Description

@fullsend-ai-retro

What happened

PR #1178 included commit 2a0be48 with message style: ruff-format unicode_posttool.py. The merge queue CI run (26467180105) failed because the .gitlint CT1 rule only allows feat, fix, refactor, docs, test, chore, ci, perf — not style. The PR was ultimately merged directly by waynesun09, bypassing the failed merge queue check.

What could go better

The style prefix is part of the Conventional Commits spec and is commonly used for formatting-only changes (exactly what happened here — running ruff-format). The repo's CLAUDE.md and CONTRIBUTING.md reference Conventional Commits, but the gitlint config is stricter than the spec. This creates a gap where valid conventional commits fail CI. High confidence this is a real issue — the evidence is direct (CI failure log shows the exact rule violation).

Proposed change

Update .gitlint (or equivalent commit-lint config) to add style to the CT1 allowed prefixes list. Also consider adding build and revert which are other standard Conventional Commits types that may be missing. The full standard set is: feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert.

Validation criteria

After the change, style: prefixed commits should pass the commit-lint CI job. Verify by checking that the next merge queue run with a style: commit does not fail on CT1.


Generated by retro agent from #1178

Metadata

Metadata

Assignees

No one assigned

    Labels

    component/ciCI pipelines and checksgood-fullsend-issueSuitable for fullsend to tackle autonomously once self-hostedpriority/mediumNormal priority, plan for next cycleready-to-codeTriaged and ready for the code agenttype/choreMaintenance and housekeeping tasks

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions