Review agent should cross-reference triage findings when reviewing PRs linked to triaged issues

[fullsend-ai-retro]

What happened

The triage agent on issue #59 flagged a specific implementation concern: because init_schema() uses INSERT OR IGNORE, existing users who already have a database won't pick up the new default for hide_stale_sessions. The triage bot recommended verifying whether a migration step or fallback logic is needed. When PR #60 was opened, it did not address this concern — it only changed DEFAULT_SETTINGS without adding migration logic. The review agent approved the PR without flagging the gap. The triage bot also proposed two specific test cases (verifying the default is '1' and verifying user overrides are preserved), neither of which appeared in the PR. The review did not note their absence.

What could go better

The review agent should incorporate context from the originating issue's triage summary when one exists. The triage agent's implementation notes and proposed test cases represent domain-specific guidance that was generated earlier in the pipeline — ignoring them at review time means the pipeline's own earlier analysis gets wasted. I'm fairly confident this is a real gap: the triage agent explicitly called out a migration risk, and the review agent had no mechanism to surface or validate that concern. The doc findings the review did catch were lower-impact than the migration issue it missed.

Proposed change

In the review agent's context assembly (likely in agents/review.md or scripts/pre-review.sh), when the PR is linked to an issue that has a triage bot comment (identifiable by the <!-- fullsend:triage-agent --> marker or similar), fetch and include that triage summary in the review agent's context. The review prompt should instruct the agent to cross-check: (1) were implementation concerns from triage addressed? (2) were suggested test cases included or explicitly deemed unnecessary? This could be implemented as a pre-review script step that fetches the linked issue's triage comment and injects it into the agent's context, or as an addition to the review agent's prompt instructing it to check the linked issue.

Validation criteria

On the next 5 PRs linked to triaged issues where the triage bot flagged implementation concerns or suggested test cases, the review agent should reference those concerns in its review output — either confirming they were addressed or flagging them as gaps. Measure by checking whether review comments mention triage-identified risks.

---

Generated by retro agent from agentshed/seshi#60

[fullsend-ai-triage]

Triage Summary

Severity: medium | Category: feature

Problem

The review agent currently fetches linked issue content for intent context (pr-review skill, step 2) but does not parse or cross-check triage agent findings from those issues. When the triage agent flags implementation concerns or proposes test cases, the review agent has no mechanism to validate whether those recommendations were addressed in the PR.

Root Cause

The pr-review skill treats linked issue content as unstructured text for intent alignment. There is no step to identify triage bot comments, extract structured findings, or pass them to the code-review skill for cross-checking.

Recommended Approach

1. Add a sub-step in pr-review skill (after step 2): scan linked issue comments for triage agent markers, extract triage summary content (implementation concerns, proposed test cases)
2. Pass triage context to code-review skill: similar to how prior review findings are passed for severity anchoring
3. Add cross-check instructions: instruct the code-review skill to verify whether flagged concerns were addressed and proposed tests were included
4. Consider pre-fetch pattern: follow the prior-review.txt pattern — a pre-review script step that writes triage findings to a file mounted into the harness

Key files to modify:

• internal/scaffold/fullsend-repo/skills/pr-review/SKILL.md — add triage extraction sub-step
• internal/scaffold/fullsend-repo/skills/code-review/SKILL.md — add cross-check instructions
• Optionally: scripts/pre-review.sh and harness/review.yaml for pre-fetch

Proposed Test Case

Scenario: Review agent cross-checks triage findings
  Given an issue with a triage comment containing:
    - Implementation concern: "migration logic needed for schema change"
    - Proposed test case: "verify default value for new column"
  And a PR linked to that issue that does NOT address the concern
  When the review agent reviews the PR
  Then the review output references the triage concern
  And the review flags the missing test case
  And the finding severity is at least medium

Edge cases:
  - PR with no linked issue -> skip triage cross-check gracefully
  - Linked issue with no triage comment -> skip gracefully
  - Multiple linked issues with triage comments -> aggregate findings

---

Labels: Review agent feature touching pr-review and code-review skills, filed by retro agent with medium priority based on pipeline improvement impact.