Close issue #1067 as fixed by PR #1348 to prevent redundant code agent work

[fullsend-ai-retro]

What happened

PR #1348 added diff-hunk validation to findingsToReviewComments in internal/cli/postreview.go, which prevents the 422 errors described in #1067. The fix validates inline comment line numbers against parsed @@ ... @@ hunk headers before submission, and falls back gracefully (skips line filtering) for binary/truncated patches with empty hunks. However, #1067 remains open with the ready-to-code label, meaning a code agent could be dispatched to implement a fix that already exists.

What could go better

When a human fixes an issue outside the normal agent workflow (i.e., the PR branch is not agent/{issue}-{slug}), there is no automation linking the PR back to the issue for closure. The human author didn't reference #1067 in the PR (only the PR description mentions the symptom, not the issue number). This creates a risk of redundant work: a code agent could be dispatched on #1067 and spend tokens reimplementing something that already shipped. Confidence: high — the PR directly addresses the problem described in #1067.

Proposed change

Close issue #1067 as fixed by PR #1348. Additionally, consider adding guidance to CONTRIBUTING.md or the PR template reminding authors to reference related issues with Fixes #NNN or Closes #NNN so GitHub auto-closes them on merge. This is a lightweight process improvement that would prevent orphaned issues after human-authored fixes.

Validation criteria

Issue #1067 is closed. No code agent run is dispatched against #1067 after this retro.

---

Generated by retro agent from #1348

[fullsend-ai-triage]

Triage Summary

Severity: Low · Category: Housekeeping / Process

Problem

Issue #1067 is still open with the ready-to-code label, but the underlying problem (GitHub 422 errors on inline review comments) was already fixed by PR #1348, which merged on 2026-05-22. Because that PR did not include a Fixes #1067 keyword, GitHub did not auto-close the issue. This creates a risk of a code agent being dispatched redundantly.

Verified Facts

• PR fix: validate inline review comment lines against diff hunks #1348 is merged and implements diff-hunk validation in findingsToReviewComments, directly addressing the 422 errors described in post-review: handle GitHub API 422 on inline comment submission gracefully #1067.
• Issue post-review: handle GitHub API 422 on inline comment submission gracefully #1067 is still open with labels ready-to-code, type/bug, and area/review-agent.

Recommended Actions

1. Close issue post-review: handle GitHub API 422 on inline comment submission gracefully #1067 as completed, referencing PR fix: validate inline review comment lines against diff hunks #1348.
2. Add guidance to CONTRIBUTING.md or the PR template reminding authors to use Fixes #NNN / Closes #NNN keywords so GitHub auto-closes related issues on merge.

Proposed Test Case

No automated test — this is a process improvement.

Validation:
- Confirm #1067 is closed after this issue is addressed
- Confirm CONTRIBUTING.md includes guidance on issue-linking keywords
- Confirm no code agent run is dispatched against #1067

This is a straightforward housekeeping task ready for implementation.

---

Labels: Retro agent identified a process gap; this is a chore involving the review agent area and has low priority.