Skip to content

security: run OutputPipeline on post-comment before forge API post #1229

@ifireball

Description

@ifireball

Summary

fullsend post-comment reads agent output and posts directly to the GitHub API without calling OutputPipeline(). If invoked standalone (outside a fullsend run that already scanned output files), content can reach the forge with:

  • Unredacted secrets (API keys, tokens)
  • Zero-width–obfuscated tokens that would be caught after unicode normalization + redaction

Context

Identified during review of #1178 (fix for #444). That PR wires OutputPipeline() into sandbox post-tool hooks, fullsend scan output, and scanOutputFiles, but not this command.

Suggested fix

Before posting, run security.OutputPipeline().Scan() on the comment body (same pattern as fullsend scan output in internal/cli/scan.go).

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions