Follow-up from PR #1225: No dedicated test for PerRepoDefaultRoles(). Other role functions (ValidRoles, Defaul...

[fullsend-ai-review]

Review follow-up

• PR: fix(#1220): add fix role to PerRepoDefaultRoles for dispatch loop #1225
• Severity: low
• Category: test-coverage
• Location: internal/config/config_test.go

Finding

No dedicated test for PerRepoDefaultRoles(). Other role functions (ValidRoles, DefaultAgentRoles) have explicit tests, but PerRepoDefaultRoles() lacks one. Adding a test would prevent future regressions where a role is accidentally omitted.

Suggested remediation

Add a TestPerRepoDefaultRolesIncludesFix test asserting all expected roles are present, similar to TestValidRoles.

---

Generated by the fullsend review agent from an approved PR. The PR was approved because this finding was non-blocking, but it was marked actionable so it is tracked separately.

[fullsend-ai-triage]

Triage Summary

This is a straightforward test-coverage gap for PerRepoDefaultRoles() in internal/config/config_test.go. Peer functions ValidRoles() and DefaultAgentRoles() both have dedicated tests, but PerRepoDefaultRoles() does not.

Recommended fix: Add a TestPerRepoDefaultRoles test following the same pattern as TestValidRoles (line 11 of config_test.go).

Note: PR #1225 is currently open and adds the fix role to PerRepoDefaultRoles(). The ideal approach is to include this test in that PR so the assertions match the updated function. If written separately, the test should account for the upcoming change.

Proposed test

func TestPerRepoDefaultRoles(t *testing.T) {
	roles := PerRepoDefaultRoles()
	// fullsend is excluded in per-repo mode
	assert.NotContains(t, roles, "fullsend")
	assert.Contains(t, roles, "triage")
	assert.Contains(t, roles, "coder")
	assert.Contains(t, roles, "review")
	assert.Contains(t, roles, "retro")
	assert.Contains(t, roles, "prioritize")
	// Verify all returned roles are valid
	for _, r := range roles {
		assert.Contains(t, ValidRoles(), r)
	}
}

---

Labels: This is a Go test-coverage chore with clear implementation path. Marking as ready-to-code and go since it's a straightforward Go test addition. Priority is low as it's non-blocking test coverage.