Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use with Angular 11 #136

Closed
alihoseiny opened this issue Apr 5, 2021 · 3 comments
Closed

Unable to use with Angular 11 #136

alihoseiny opened this issue Apr 5, 2021 · 3 comments

Comments

@alihoseiny
Copy link

I'm submitting a ... (check one with "x")

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X ] Bug report  <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Support request => <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request

Current behavior

Getting error TS2694: Namespace '"node_modules/@angular/core/core"' has no exported member 'ɵɵNgModuleDefWithMeta'. exception after updating to Angular 11.
This plugin is no longer usable for newer versions of Angular.

@m7mdbadawy
Copy link

I made a pull request for angular 11 here maybe it will help you #137

I didn't encounter your problem so I am not sure if it fixes it

@mczachurski
Copy link

I'm experiencing same issue. It's easy to reproduce. We have to create new application (by Angular CLI 12):

$ ng new TestApp
$ cd TestApp
$ npm install @ngx-cache/core @ngx-cache/platform-browser --save

Add to app.component.ts file function:

@Cached('some-string')
getSomeStringValue(): string {
    return 'some string value';
}

And after: ng build I have an error:

Error: node_modules/@ngx-cache/core/cache.service.d.ts:32:22 - error TS2724: '"/Users/mczachurski/Downloads/Angular12/TestApp3/node_modules/@angular/core/core"' has no exported member named 'ɵɵInjectableDef'. Did you mean 'ɵgetInjectableDef'?

32     static ɵprov: i0.ɵɵInjectableDef<CacheService>;

Thus it seems that library cannot be used in new Angular applications at all. Do you have any plans to merge PR and create new NPM version?

@fulls1z3
Copy link
Owner

fulls1z3 commented Jul 8, 2021

see #141

@fulls1z3 fulls1z3 closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants