Fix major issue by sonar cloud

Author: fugerit79

fj-tool/src/main/java/org/fugerit/java/tool/ToolHandlerHelper.java

@@ -79,7 +79,7 @@ public String getHelp() {
 			StreamIO.pipeStream( is , os , StreamIO.MODE_CLOSE_BOTH );
 			help = os.toString();
 		} catch (Exception e) {
-			logger.info( "Failed to load help : "+resName );
+			logger.info( "Failed to load help : {}", resName );
 		}
 		return help;
 	}

fj-tool/src/main/java/org/fugerit/java/tool/compress/CompressUtils.java

@@ -6,6 +6,8 @@
 
 public class CompressUtils {
 
+	private CompressUtils() {}
+	
 	public static void compress7Zipfile( File sourceDir, File  outputFile) throws IOException, FileNotFoundException {
 		compressZipfile(sourceDir, outputFile);
 	}

fj-tool/src/main/java/org/fugerit/java/tool/fixed/ExtractFixedConfigHandler.java

@@ -41,6 +41,19 @@ public class ExtractFixedConfigHandler extends ToolHandlerHelper {
 	 */
 	public static final String PARAM_OUTPUT_BEAN = "output-bean";
 
+	private int handleRow( int start, String length, String name, List<FixedFieldDescriptor> listFields, int rowCount ) {
+		try {
+			Integer len = Integer.valueOf( length );
+			FixedFieldDescriptor ffd = new FixedFieldDescriptor( name, start, len );
+			logger.info( String.valueOf( ffd ) );
+			listFields.add( ffd );
+			start+= len;
+		} catch (Exception e) {
+			logger.warn( "Failed parsing of length for row : {} name : {}", rowCount, name );
+		}
+		return start;
+	}
+	
 	@Override
 	public int handleWorker(Properties params) throws RunToolException {
 		int exit = EXIT_OK;
@@ -56,15 +69,7 @@ public int handleWorker(Properties params) throws RunToolException {
 				Row row = rows.next();
 				String name = row.getCell( 0 ).getStringCellValue();
 				String length = row.getCell( 1 ).getStringCellValue();
-				try {
-					Integer len = Integer.valueOf( length );
-					FixedFieldDescriptor ffd = new FixedFieldDescriptor( name, start, len );
-					logger.info( String.valueOf( ffd ) );
-					listFields.add( ffd );
-					start+= len;
-				} catch (Exception e) {
-					logger.warn( "Failed parsing of length for row : "+rowCount+" name "+name );
-				}
+				start = this.handleRow(start, length, name, listFields, rowCount);
 				rowCount++;
 			}
 			// generating xml output

fj-tool/src/main/java/org/fugerit/java/tool/fixed/FixedToExcel.java

@@ -82,7 +82,7 @@ public int handleWorker(Properties params) throws RunToolException {
 					}
 					currentRow++;
 					if ( currentRow%1000 == 0 ) {
-						System.out.println( "CURRENT ROW "+currentRow );
+						logger.debug( "CURRENT ROW {}", currentRow );
 					}
 				}			
 				workbook.close();

fj-tool/src/main/java/org/fugerit/java/tool/sql/ExportQuery.java

@@ -46,20 +46,20 @@ private void closeFile( PrintWriter pw, String format ) {
 		pw.println( "</table>" );
 	}
 
-	private void addRecord( PrintWriter pw, String[] record, boolean header ) {
+	private void addRecord( PrintWriter pw, String[] currentRecord, boolean header ) {
 		pw.println( "<tr>" );
 		String openTag = "<td>";
 		String closeTag = "</td>";
 		if ( header ) {
 			openTag = "<th>";
 			closeTag = "</th>";
 		}
-		for ( int k=0; k<record.length; k++ ) {
+		for ( int k=0; k<currentRecord.length; k++ ) {
 			pw.print( openTag );
-			if ( StringUtils.isEmpty( record[k] ) ) {
+			if ( StringUtils.isEmpty( currentRecord[k] ) ) {
 				pw.print( "&nbsp;" );	
 			} else {
-				pw.print( record[k] );
+				pw.print( currentRecord[k] );
 			}
 			pw.println( closeTag );
 		}
@@ -100,15 +100,15 @@ public int handleWorker(Properties params) throws RunToolException {
 				}
 				addRecord( pw , head , true );
 				while ( rs.next() ) {
-					String record[] = new String[rsmd.getColumnCount()];
+					String localRecord[] = new String[rsmd.getColumnCount()];
 					for ( int k=0; k<rsmd.getColumnCount(); k++ ) {
 						Object obj = rs.getObject( k+1 );
 						if ( obj == null ) {
 							obj = "";
 						}
-						record[k] = String.valueOf( obj );
+						localRecord[k] = String.valueOf( obj );
 					}
-					addRecord( pw , record , false );				
+					addRecord( pw , localRecord , false );				
 				}
 				closeFile( pw, format );
 			}