Fix issues for sonar cloud scan #51

Author: fugerit79

fj-doc-base-json/src/test/java/test/org/fugerit/java/doc/base/facade/TestDocFacadeSourceJson.java

@@ -3,7 +3,6 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.fail;
 
-import org.fugerit.java.doc.base.config.DocException;
 import org.fugerit.java.doc.base.facade.DocFacadeSource;
 import org.junit.Test;
 import org.slf4j.Logger;
@@ -18,7 +17,7 @@ private void textSupportedParser( boolean expected, int sourceType ) {
 		try {
 			supported = DocFacadeSource.getInstance().isSourceSupported(sourceType);
 			assertEquals( "Failed doc parser supported check", expected , supported );
-		} catch (DocException e) {
+		} catch (Exception e) {
 			String message = "Error : "+e;
 			logger.error( message, e );
 			fail( message );

fj-doc-base-yaml/src/test/java/test/org/fugerit/java/doc/base/facade/TestDocFacadeSourceYaml.java

@@ -3,7 +3,6 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.fail;
 
-import org.fugerit.java.doc.base.config.DocException;
 import org.fugerit.java.doc.base.facade.DocFacadeSource;
 import org.junit.Test;
 import org.slf4j.Logger;
@@ -18,7 +17,7 @@ private void textSupportedParser( boolean expected, int sourceType ) {
 		try {
 			supported = DocFacadeSource.getInstance().isSourceSupported(sourceType);
 			assertEquals( "Failed doc parser supported check", expected , supported );
-		} catch (DocException e) {
+		} catch (Exception e) {
 			String message = "Error : "+e;
 			logger.error( message, e );
 			fail( message );

fj-doc-base/src/main/java/org/fugerit/java/doc/base/facade/DocFacadeSource.java

@@ -12,9 +12,20 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import lombok.Getter;
+
 public class DocFacadeSource {
 
-	private DocFacadeSource() {} // java:S1118
+	@Getter private DocFacadeSourceConfig docFacadeSourceConfig;
+	
+	public DocFacadeSource(DocFacadeSourceConfig docFacadeSourceConfig) {
+		super();
+		this.docFacadeSourceConfig = docFacadeSourceConfig;
+	}
+
+	public DocFacadeSource() {
+		this( DocFacadeSourceConfig.DEFAULT_CONFIG );
+	}
 
 	public static final int SOURCE_TYPE_XML = 1;
 
@@ -26,10 +37,10 @@ private DocFacadeSource() {} // java:S1118
 
 	private static final Logger logger = LoggerFactory.getLogger( DocFacadeSource.class );
 
-	private static final DocFacadeSource INSTANCE = new DocFacadeSource();
+	private static final DocFacadeSource DEFAULT_INSTANCE = new DocFacadeSource();
 
 	public static DocFacadeSource getInstance() {
-		return INSTANCE;
+		return DEFAULT_INSTANCE;
 	}
 
 	private static final String TYPE_SOURCE_XML = DocXmlParser.class.getName();							// xml parser is always supported
@@ -53,7 +64,11 @@ public DocParser getParserForSource( int sourceType ) {
 				parser = (DocParser) ClassHelper.newInstance( type );
 			}
 		} catch (Exception e) {
-			logger.warn( "Failed to load parser for source type : {} ({})", sourceType, e.toString() );
+			if ( this.docFacadeSourceConfig.isFailOnSourceModuleNotFound() ) {
+				throw new ConfigRuntimeException( "Exception getting parser for sourceType : "+sourceType+" - "+e, e );
+			} else {
+				logger.warn( "Failed to load parser for source type : {} ({})", sourceType, e.toString() );
+			}
 		}
 		return parser;
 	}

fj-doc-base/src/main/java/org/fugerit/java/doc/base/facade/DocFacadeSourceConfig.java

@@ -0,0 +1,18 @@
+package org.fugerit.java.doc.base.facade;
+
+import lombok.AllArgsConstructor;
+import lombok.Data;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.With;
+
+@Data
+@NoArgsConstructor
+@AllArgsConstructor
+public class DocFacadeSourceConfig {
+
+	public static final DocFacadeSourceConfig DEFAULT_CONFIG = new DocFacadeSourceConfig().withFailOnSourceModuleNotFound(false);
+	
+	@Getter @With private boolean failOnSourceModuleNotFound; 
+
+}

fj-doc-base/src/test/java/test/org/fugerit/java/doc/base/facade/TestDocFacadeSource.java

@@ -3,7 +3,6 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.fail;
 
-import org.fugerit.java.doc.base.config.DocException;
 import org.fugerit.java.doc.base.facade.DocFacadeSource;
 import org.junit.Test;
 import org.slf4j.Logger;
@@ -18,7 +17,7 @@ private void textSupportedParser( boolean expected, int sourceType ) {
 		try {
 			supported = DocFacadeSource.getInstance().isSourceSupported(sourceType);
 			assertEquals( "Failed doc parser supported check", expected , supported );
-		} catch (DocException e) {
+		} catch (Exception e) {
 			String message = "Error : "+e;
 			logger.error( message, e );
 			fail( message );

fj-doc-playground-quarkus/src/test/java/org/fugerit/java/GreetingResourceTest.java

@@ -7,10 +7,10 @@
 import static org.hamcrest.CoreMatchers.is;
 
 @QuarkusTest
-public class GreetingResourceTest {
+class GreetingResourceTest {
 
     @Test
-    public void testHelloEndpoint() {
+    void testHelloEndpoint() {
         given()
           .when().get( TestConsts.BASE_API_PATH+"/hello" )
           .then()

fj-doc-playground-quarkus/src/test/java/org/fugerit/java/doc/playground/ValRestTest.java

@@ -9,10 +9,10 @@
 import org.fugerit.java.TestConsts;
 
 @QuarkusTest
-public class ValRestTest {
+class ValRestTest {
 
     @Test
-    public void testHelloEndpoint() {
+    void testHelloEndpoint() {
         given()
           .when().get( TestConsts.BASE_API_PATH+"/val/supported_extensions" )
           .then()