Refactor sitemap generation and routing logic. Simplify the route for the sitemap and remove the need for a filename parameter in the SitemapController.

Author: thejmitchener

README.md

@@ -116,7 +116,7 @@ php artisan sitemap:generate
 You can link to the sitemap with:
 
 ```blade
-route('sitemap', ['filename' => 'sitemap.xml'])
+route('sitemap')
 ```
 
 

src/Http/Controllers/SitemapController.php

@@ -15,6 +15,7 @@
 class SitemapController extends BaseController
 {
     protected Sitemap $sitemap;
+    protected $defaultFilename = 'sitemap.xml';
 
     /**
      * SitemapController constructor.
@@ -31,9 +32,9 @@ public function __construct(Sitemap $sitemap)
      *
      * @throws FileNotFoundException
      */
-    public function __invoke(?string $filename): Response
+    public function __invoke(): Response
     {
-        $contents = $this->sitemap->getSitemapContents($filename);
+        $contents = $this->sitemap->getSitemapContents($this->defaultFilename);
 
         return response($contents, 200)
             ->header('Content-Type', 'application/xml');

src/SitemapServiceProvider.php

@@ -36,8 +36,7 @@ public function configurePackage(Package $package): void
      */
     public function PackageRegistered(): void
     {
-        Route::get('/{filename}', SitemapController::class)
-            ->where('filename', '.*\.xml$')
+        Route::get('sitemap.xml', SitemapController::class)
             ->name('sitemap');
     }
 }