Refactor SitemapController and SitemapServiceProvider to allow for a default sitemap file name and update the route to only accept requests for the specific sitemap.xml file.

Author: thejmitchener

src/Http/Controllers/SitemapController.php

@@ -27,12 +27,15 @@ public function __construct(Sitemap $sitemap)
     /**
      * Retrieve the content of the specified sitemap file.
      *
-     * @param  string  $filename  The name of the sitemap file.
+     * @param string|null $filename The name of the sitemap file.
      *
+     * @return Response
      * @throws FileNotFoundException
      */
-    public function __invoke(string $filename): Response
+    public function __invoke(string $filename = null): Response
     {
+        $filename = 'sitemap.xml';
+
         $contents = $this->sitemap->getSitemapContents($filename);
 
         return response($contents, 200)

src/SitemapServiceProvider.php

@@ -36,7 +36,8 @@ public function configurePackage(Package $package): void
      */
     public function PackageRegistered(): void
     {
-        Route::get('/{filename}', SitemapController::class)
-            ->where('filename', '.*\.xml$')->name('sitemap');
+        Route::get('/sitemap.xml', SitemapController::class)
+            ->where('filename', '.*\.xml$')
+            ->name('sitemap');
     }
 }