Removed deprecated language constructs usage (! and := for reference cells)

Author: Andrii Chebukin

src/FSharp.Data.GraphQL.Client.DesignTime/ProvidedTypesHelper.fs

@@ -631,14 +631,14 @@ module internal Provider =
                 |> makeOption
             | _ -> failwith "Could not find a schema type based on a type reference. The reference has an invalid or unsupported combination of Name, Kind and OfType fields."
         and resolveProvidedType (itype : IntrospectionType) : ProvidedTypeDefinition =
-            if (!providedTypes).ContainsKey(itype.Name)
-            then (!providedTypes).[itype.Name]
+            if providedTypes.Value.ContainsKey(itype.Name)
+            then providedTypes.Value.[itype.Name]
             else
                 let metadata = { Name = itype.Name; Description = itype.Description }
                 match itype.Kind with
                 | TypeKind.OBJECT ->
                     let tdef = ProvidedRecord.preBuildProvidedType(metadata, None)
-                    providedTypes := (!providedTypes).Add(itype.Name, tdef)
+                    providedTypes.Value <- providedTypes.Value.Add(itype.Name, tdef)
                     let properties =
                         itype.Fields
                         |> Option.defaultValue [||]
@@ -647,7 +647,7 @@ module internal Provider =
                     upcast ProvidedRecord.makeProvidedType(tdef, properties, explicitOptionalParameters)
                 | TypeKind.INPUT_OBJECT ->
                     let tdef = ProvidedRecord.preBuildProvidedType(metadata, None)
-                    providedTypes := (!providedTypes).Add(itype.Name, tdef)
+                    providedTypes.Value <- providedTypes.Value.Add(itype.Name, tdef)
                     let properties =
                         itype.InputFields
                         |> Option.defaultValue [||]
@@ -656,15 +656,15 @@ module internal Provider =
                     upcast ProvidedRecord.makeProvidedType(tdef, properties, explicitOptionalParameters)
                 | TypeKind.INTERFACE | TypeKind.UNION ->
                     let bdef = ProvidedInterface.makeProvidedType(metadata)
-                    providedTypes := (!providedTypes).Add(itype.Name, bdef)
+                    providedTypes.Value <- providedTypes.Value.Add(itype.Name, bdef)
                     bdef
                 | TypeKind.ENUM ->
                     let items =
                         match itype.EnumValues with
                         | Some values -> values |> Array.map (fun value -> value.Name)
                         | None -> [||]
                     let tdef = ProvidedEnum.makeProvidedType(itype.Name, items)
-                    providedTypes := (!providedTypes).Add(itype.Name, tdef)
+                    providedTypes.Value <- providedTypes.Value.Add(itype.Name, tdef)
                     tdef
                 | _ -> failwithf "Type \"%s\" is not a Record, Union, Enum, Input Object, or Interface type." itype.Name
         let ignoredKinds = [TypeKind.SCALAR; TypeKind.LIST; TypeKind.NON_NULL]
@@ -674,7 +674,7 @@ module internal Provider =
             | Some trefs -> trefs |> Array.map (getSchemaType >> resolveProvidedType)
             | None -> [||]
         let getProvidedType typeName =
-            match (!providedTypes).TryFind(typeName) with
+            match providedTypes.Value.TryFind(typeName) with
             | Some ptype -> ptype
             | None -> failwithf "Expected to find a type \"%s\" on the schema type map, but it was not found." typeName
         schemaTypes
@@ -683,7 +683,7 @@ module internal Provider =
                 let itype = getProvidedType kvp.Value.Name
                 let ptypes = possibleTypes kvp.Value
                 ptypes |> Array.iter (fun ptype -> ptype.AddInterfaceImplementation(itype)))
-        !providedTypes
+        providedTypes.Value
 
     let makeProvidedType(asm : Assembly, ns : string, resolutionFolder : string) =
         let generator = ProvidedTypeDefinition(asm, ns, "GraphQLProvider", None)

src/FSharp.Data.GraphQL.Server/Planning.fs

@@ -246,10 +246,10 @@ and private planSelection (ctx: PlanningContext) (selectionSet: Selection list)
                     | Planned -> fields @ [ executionPlan ]
             | FragmentSpread spread ->
                 let spreadName = spread.Name
-                if !visitedFragments |> List.exists (fun name -> name = spreadName)
+                if visitedFragments.Value |> List.exists (fun name -> name = spreadName)
                 then fields // Fragment already found
                 else
-                    visitedFragments := spreadName::!visitedFragments
+                    visitedFragments.Value <- spreadName::visitedFragments.Value
                     match ctx.Document.Definitions |> List.tryFind (function FragmentDefinition f -> f.Name.Value = spreadName | _ -> false) with
                     | Some (FragmentDefinition fragment) when doesFragmentTypeApply ctx.Schema fragment parentDef ->
                         // Retrieve fragment data just as it was normal selection set
@@ -288,10 +288,10 @@ and private planAbstraction (ctx:PlanningContext) (selectionSet: Selection list)
                 | Planned -> Map.merge (fun _ -> deepMerge) fields infoMap
             | FragmentSpread spread ->
                 let spreadName = spread.Name
-                if !visitedFragments |> List.exists (fun name -> name = spreadName)
+                if visitedFragments.Value |> List.exists (fun name -> name = spreadName)
                 then fields // Fragment already found
                 else
-                    visitedFragments := spreadName::!visitedFragments
+                    visitedFragments.Value <- spreadName::visitedFragments.Value
                     match ctx.Document.Definitions |> List.tryFind (function FragmentDefinition f -> f.Name.Value = spreadName | _ -> false) with
                     | Some (FragmentDefinition fragment) ->
                         // Retrieve fragment data just as it was normal selection set

src/FSharp.Data.GraphQL.Shared/Parser.fs

@@ -176,7 +176,7 @@ module internal Internal =
   // 2.9 Value
   //   Variable|IntValue|FloatValue|StringValue|
   //   BooleanValue|NullValue|EnumValue|ListValue|ObjectValue
-  inputValueRef :=
+  inputValueRef.Value <-
     choice [ variable |>> Variable <?> "Variable"
              (attempt floatValue) |>> FloatValue <?> "Float"
              integerValue |>> IntValue <?> "Integer"
@@ -222,7 +222,7 @@ module internal Internal =
   let nonNullType =
     (listType <|> namedType) .>> pchar '!'
     |>> NonNullType <?> "NonNullType"
-  inputTypeRef :=
+  inputTypeRef.Value <-
     choice [ attempt nonNullType
              namedType
              listType ]
@@ -264,10 +264,10 @@ module internal Internal =
 
     pstring "..." .>> whitespaces >>. (inlineFragment <|> fragmentSpread)  <?> "Fragment"
 
-  selectionRef :=
+  selectionRef.Value <-
     field <|> selectionFragment  <?> "Selection"
 
-  selectionSetRef :=
+  selectionSetRef.Value <-
     betweenCharsMany1 '{' '}' selection <?> "SelectionSet"
 
 

tests/FSharp.Data.GraphQL.Tests/Program.fs

@@ -15,7 +15,7 @@ module Program =
         runner.Start(null)
         finished.WaitOne() |> ignore
         finished.Dispose()
-        !result
+        result.Value
 
 [<assembly: CollectionBehavior(DisableTestParallelization = true)>]
-do()
+do()