Skip to content

Commit b487c08

Browse files
xperiandriclaude
andcommitted
fixup! feat: HashMap and IMap modules with the vocabulary of the FSharp.Core Map module
The helpers of the map modules are in Helper/Dictionaries.fs, not in Helper.fs, since the split of that file. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1 parent 3e234e8 commit b487c08

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎src/FSharp.Collections.Immutable/HashMap/HashMap.fs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ open System.Collections.Generic
66
open System.Collections.Immutable
77

88
// The functions call the members of ImmutableDictionary where it has them (ADR 0001, D5) and visit the bindings with the
9-
// algorithms that the map modules share (`Dictionaries` in Helper.fs). The transformations fill a builder that has the
10-
// comparers of the input, so that they keep them (D5, comparers). The functions that create a map from bindings are the
11-
// members of CustomComparersHashMap (D12) and the static members of HashMapExtensions (D13); the module has none of their
12-
// names, so that `HashMap.ofSeq` reaches the overloads of the extensions.
9+
// algorithms that the map modules share (`Dictionaries` in Helper/Dictionaries.fs). The transformations fill a builder
10+
// that has the comparers of the input, so that they keep them (D5, comparers). The functions that create a map from
11+
// bindings are the members of CustomComparersHashMap (D12) and the static members of HashMapExtensions (D13); the module
12+
// has none of their names, so that `HashMap.ofSeq` reaches the overloads of the extensions.
1313

1414
// ---- Creation ----
1515

‎src/FSharp.Collections.Immutable/HashMap/IMap.fs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ open System.Collections.Generic
55
open System.Collections.Immutable
66

77
// The functions call the members of the interface where it has them (ADR 0001, D5) and visit the bindings with the
8-
// algorithms that the map modules share (`Dictionaries` in Helper.fs). The interface hides the comparers of a map, so the
9-
// transformations that keep the type of the values build their result with `Clear` and `AddRange` of the map itself,
10-
// which keep its implementation and its comparers; the ones that change the type of the values build a hash map with the
11-
// default comparers (D5, comparers).
8+
// algorithms that the map modules share (`Dictionaries` in Helper/Dictionaries.fs). The interface hides the comparers of
9+
// a map, so the transformations that keep the type of the values build their result with `Clear` and `AddRange` of the
10+
// map itself, which keep its implementation and its comparers; the ones that change the type of the values build a hash
11+
// map with the default comparers (D5, comparers).
1212

1313
// ---- Properties ----
1414

0 commit comments

Comments
 (0)