Repository navigation
Commit 82759f3
fixup! feat:
The helpers of the branch get the documentation of `Arrays` and `ParallelArrays`: an explicit `<summary>`,
`<param>`, `<returns>`, `<exception>` and `<remarks>` for every function, and `<see cref>` instead of `<c>` for
every function and type of FSharp.Core. The remarks say why the function exists.
- `ListChecks`: every check names the functions of `List` that it serves, the exception that it throws (the
type, the message and the parameter name) and, where a sibling check exists, why the two are separate
(`item` and `removeAt` differ in the message, `replicate` and `nonNegative` in the value, `exists2` and
`sameLengths` in the names, `zip3` and `map3` in the lengths, `notEmpty` and `notEmptySequence` in the
word). `foldBack2` says why it has two branches, and `transpose` which pair of lists it reports, checked
against `local.fs` of FSharp.Core. The private literal `IndexOutsideListBounds` says which five functions
of `List` write it and why it is not in `ErrorStrings`.
- `ListArrays`: the summaries, the descriptions of the parameters and of the results are those of the
functions of `List`. Each remark says why the function is not `Array.iter2` and its siblings: they compare
the lengths before they call the callback and report arrays, where the functions of `List` call the
callback for the common prefix first and report lists.
- `Snapshot`, `Lengths` (with its private `countUpTo`), `DescendingSorts` and `ListRanges`: parameters,
results and exceptions, the reason for each function, and the functions that call it. The private literal
of `ListRanges` said that its message is the one of System.Collections.Immutable; no resource of that
assembly holds it. The runtime throws the message from ``List`1.BinarySearch`` with "array" and "source
collection", and the literal says "list", so the comment says that.
- The three functions that the branch adds to `Raise` (`invalidArg2ListsDifferent`,
`invalidArgRandomizerOutOfRange` and `invalidOpListEmpty`) replace one-line comments with backticks.
No code changed: without the doc comments, every file is identical to the file before. The build with
`--warnon:3390`, `dotnet fantomas --check` and a check of every `cref` against the generated XML
documentation, FSharp.Core and the reference assemblies are clean.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>IndexedList and IIndexedList modules with the vocabulary of the FSharp.Core List module1 parent d416a34 commit 82759f3
7 files changed
Lines changed: 766 additions & 96 deletions
File tree
- src/FSharp.Collections.Immutable/Helper
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | | - | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
35 | | - | |
36 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
37 | 48 | | |
38 | 49 | | |
39 | 50 | | |
| |||
49 | 60 | | |
50 | 61 | | |
51 | 62 | | |
| 63 | + | |
52 | 64 | | |
53 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
54 | 74 | | |
55 | 75 | | |
56 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
24 | 41 | | |
25 | 42 | | |
26 | 43 | | |
| |||
0 commit comments