Skip to content

Commit 4b2ba96

Browse files
xperiandriclaude
andcommitted
fixup! feat: FlatList module with the vocabulary of the FSharp.Core Array module
F# ignores `[<CompiledName>]` on a module: the modules compile as `FlatList`, `Option.FlatList`, `Tuple.FlatList` and `FlatListBuilder`, as the legacy modules of the released package did. The attributes are removed, and the documentation references use the real IDs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 3b66008 commit 4b2ba96

7 files changed

Lines changed: 8 additions & 15 deletions

File tree

‎src/FSharp.Collections.Immutable/FlatList/FlatList.fs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ type FlatList<'T> = ImmutableArray<'T>
1010
// Most functions unwrap the underlying array without a copy, call the FSharp.Core Array function, and wrap its fresh
1111
// result without a copy (ADR 0001, D5), so that they have the semantics and the exceptions of the Array module (D6).
1212
[<RequireQualifiedAccess>]
13-
[<CompiledName "ImmutableArrayModule">]
1413
module FlatList =
1514

1615
// ---- Creation ----

‎src/FSharp.Collections.Immutable/FlatList/FlatList.fsi‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ type FlatList<'T> = ImmutableArray<'T>
1818
/// </para>
1919
/// <para>
2020
/// A default immutable array has no underlying array. Every function except
21-
/// <see cref="M:FSharp.Collections.Immutable.ImmutableArrayModule.IsDefault``1(System.Collections.Immutable.ImmutableArray{``0})"/>
22-
/// and <see cref="M:FSharp.Collections.Immutable.ImmutableArrayModule.IsDefaultOrEmpty``1(System.Collections.Immutable.ImmutableArray{``0})"/>
21+
/// <see cref="M:FSharp.Collections.Immutable.FlatList.IsDefault``1(System.Collections.Immutable.ImmutableArray{``0})"/>
22+
/// and <see cref="M:FSharp.Collections.Immutable.FlatList.IsDefaultOrEmpty``1(System.Collections.Immutable.ImmutableArray{``0})"/>
2323
/// throws <see cref="T:System.ArgumentNullException"/> for it, as <see cref="T:Microsoft.FSharp.Collections.ArrayModule"/>
2424
/// does for a <see langword="null"/> array.
2525
/// </para>
@@ -31,7 +31,6 @@ type FlatList<'T> = ImmutableArray<'T>
3131
/// </para>
3232
/// </remarks>
3333
[<RequireQualifiedAccess>]
34-
[<CompiledName "ImmutableArrayModule">]
3534
module FlatList =
3635

3736
// ---- Creation ----
@@ -282,7 +281,7 @@ module FlatList =
282281
/// </returns>
283282
/// <remarks>
284283
/// O(log n). The function compares with <see cref="P:Microsoft.FSharp.Core.LanguagePrimitives.FastGenericComparer``1"/>,
285-
/// the order that <see cref="M:FSharp.Collections.Immutable.ImmutableArrayModule.Sort``1(System.Collections.Immutable.ImmutableArray{``0})"/> produces.
284+
/// the order that <see cref="M:FSharp.Collections.Immutable.FlatList.Sort``1(System.Collections.Immutable.ImmutableArray{``0})"/> produces.
286285
/// </remarks>
287286
[<CompiledName "BinarySearch">]
288287
val binarySearch : value : 'T -> array : FlatList<'T> -> int when 'T : comparison
@@ -680,7 +679,7 @@ module FlatList =
680679
/// <param name="predicate">The function to test the elements.</param>
681680
/// <param name="array">The input flat list.</param>
682681
/// <returns>The elements that satisfy the predicate, in their order.</returns>
683-
/// <remarks>O(n). A synonym of <see cref="M:FSharp.Collections.Immutable.ImmutableArrayModule.Filter``1(Microsoft.FSharp.Core.FSharpFunc{``0,System.Boolean},System.Collections.Immutable.ImmutableArray{``0})"/>.</remarks>
682+
/// <remarks>O(n). A synonym of <see cref="M:FSharp.Collections.Immutable.FlatList.Filter``1(Microsoft.FSharp.Core.FSharpFunc{``0,System.Boolean},System.Collections.Immutable.ImmutableArray{``0})"/>.</remarks>
684683
[<CompiledName "Where">]
685684
val where : predicate : ('T -> bool) -> array : FlatList<'T> -> FlatList<'T>
686685

‎src/FSharp.Collections.Immutable/FlatList/FlatListBuilder.fs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,11 @@ open System.Collections.Immutable
99
/// </summary>
1010
/// <remarks>
1111
/// The builder is mutable. The functions that change it return the same builder, so that the calls chain with the pipe
12-
/// operator. <see cref="M:FSharp.Collections.Immutable.ImmutableArrayModule.CreateBuilder``1"/> creates a builder, and
13-
/// <see cref="M:FSharp.Collections.Immutable.ImmutableArrayModule.OfBuilder``1(System.Collections.Immutable.ImmutableArray{``0}.Builder)"/>
12+
/// operator. <see cref="M:FSharp.Collections.Immutable.FlatList.CreateBuilder``1"/> creates a builder, and
13+
/// <see cref="M:FSharp.Collections.Immutable.FlatList.OfBuilder``1(System.Collections.Immutable.ImmutableArray{``0}.Builder)"/>
1414
/// returns its contents as a flat list.
1515
/// </remarks>
1616
[<RequireQualifiedAccess>]
17-
[<CompiledName "ImmutableArrayBuilderModule">]
1817
module FlatListBuilder =
1918

2019
// ---- Properties ----

‎src/FSharp.Collections.Immutable/FlatList/FlatListOption.fs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ open FSharp.Collections.Immutable
55
// The functions call the FSharp.Core Array functions, which take and return options, over the underlying array, or
66
// convert the result of the default module where it implements the function itself.
77
[<RequireQualifiedAccess>]
8-
[<CompiledName "ImmutableArrayModule">]
98
module FlatList =
109

1110
// ---- Creation ----

‎src/FSharp.Collections.Immutable/FlatList/FlatListOption.fsi‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ namespace FSharp.Collections.Immutable.Option
33
open FSharp.Collections.Immutable
44

55
/// <summary>
6-
/// The functions of <see cref="T:FSharp.Collections.Immutable.ImmutableArrayModule"/> that take or return an optional
6+
/// The functions of <see cref="T:FSharp.Collections.Immutable.FlatList"/> that take or return an optional
77
/// value, with <see cref="T:Microsoft.FSharp.Core.FSharpOption`1"/> instead of
88
/// <see cref="T:Microsoft.FSharp.Core.FSharpValueOption`1"/>.
99
/// </summary>
@@ -13,7 +13,6 @@ open FSharp.Collections.Immutable
1313
/// name in <see cref="T:Microsoft.FSharp.Collections.ArrayModule"/> where that module has one.
1414
/// </remarks>
1515
[<RequireQualifiedAccess>]
16-
[<CompiledName "ImmutableArrayModule">]
1716
module FlatList =
1817

1918
// ---- Creation ----

‎src/FSharp.Collections.Immutable/FlatList/FlatListTuple.fs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ open FSharp.Collections.Immutable
55
// The functions that build a tuple per element share their algorithm with the default module and only pass another
66
// tuple constructor; the others delegate to the default module and repack the tuples, which costs no second pass.
77
[<RequireQualifiedAccess>]
8-
[<CompiledName "ImmutableArrayModule">]
98
module FlatList =
109

1110
// ---- Creation ----

‎src/FSharp.Collections.Immutable/FlatList/FlatListTuple.fsi‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ namespace FSharp.Collections.Immutable.Tuple
33
open FSharp.Collections.Immutable
44

55
/// <summary>
6-
/// The functions of <see cref="T:FSharp.Collections.Immutable.ImmutableArrayModule"/> that take or return tuples, with
6+
/// The functions of <see cref="T:FSharp.Collections.Immutable.FlatList"/> that take or return tuples, with
77
/// reference tuples instead of struct tuples.
88
/// </summary>
99
/// <remarks>
@@ -14,7 +14,6 @@ open FSharp.Collections.Immutable
1414
/// <see cref="T:Microsoft.FSharp.Collections.ArrayModule"/>.
1515
/// </remarks>
1616
[<RequireQualifiedAccess>]
17-
[<CompiledName "ImmutableArrayModule">]
1817
module FlatList =
1918

2019
// ---- Creation ----

0 commit comments

Comments
 (0)