Skip to content

Commit 7127242

Browse files
authored
Fsharp integration january 2020 (#919)
Contains commits from 32b1249 to 5a01170 from dotnet/fsharp. Notable features: * lowered allocations for large strings and char arrays (notable source file texts) * improved support for byreflike rules with regards to type abbreviations * better support for scopes in recursive modules * better location of .net core reference assemblies * lowered allocations for several internal compiler structures * better error messages for anonymous record mismatches * FSharpChecker learned how to keep background symbol uses * Project cracker/project cracker tool were removed * Better support for consuming C# inref parameters * preview-level functionality for #r "nuget" in scripts
2 parents 7920db8 + 1ffccff commit 7127242

File tree

311 files changed

+29241
-14416
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

311 files changed

+29241
-14416
lines changed

.gitignore

-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ artifacts/
99
# Patches that may have been generated by scripts.
1010
# (These aren't generally useful to commit directly; if anything, they should be applied.)
1111
scripts/*.patch
12-
1312
/fcs/FSharp.Compiler.Service/illex.fs
1413
/fcs/FSharp.Compiler.Service/ilpars.fs
1514
/fcs/FSharp.Compiler.Service/ilpars.fsi
@@ -234,7 +233,6 @@ lib/netcore/fsc/bin/
234233
msbuild.binlog
235234
/fcs/FSharp.Compiler.Service.netstandard/*.fs
236235
/fcs/FSharp.Compiler.Service.netstandard/*.fsi
237-
238236
.ionide
239237
.vscode
240238
**/.DS_Store

FSharpBuild.Directory.Build.targets

+31-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<Project>
2+
23
<Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />
34
<Import Project="eng\targets\Imports.targets" />
45
<Import Project="eng\targets\NuGet.targets" />
@@ -8,28 +9,32 @@
89
<Target Name="NoneSubstituteTextFiles"
910
Inputs="@(NoneSubstituteText)"
1011
Outputs="@(NoneSubstituteText->'$(IntermediateOutputPath)%(Filename)%(Extension)')"
11-
BeforeTargets="AssignTargetPaths;BeforeBuild">
12+
BeforeTargets="AssignTargetPaths;BeforeBuild;GenerateFSharpTextResources">
1213

1314
<PropertyGroup>
1415
<__TargetFilePath>@(NoneSubstituteText->'$(IntermediateOutputPath)%(Filename)%(Extension)')</__TargetFilePath>
1516
<__TargetFileName>@(NoneSubstituteText->'%(Filename)%(Extension)')</__TargetFileName>
17+
<__TargetLink>@(NoneSubstituteText->'%(Link)')</__TargetLink>
1618

1719
<_ReplacementText>$([System.IO.File]::ReadAllText('%(NoneSubstituteText.FullPath)'))</_ReplacementText>
1820
<_ReplacementText Condition="'%(NoneSubstituteText.Pattern1)' != ''">$(_ReplacementText.Replace('%(NoneSubstituteText.Pattern1)', '%(NoneSubstituteText.Replacement1)'))</_ReplacementText>
1921
<_ReplacementText Condition="'%(NoneSubstituteText.Pattern2)' != ''">$(_ReplacementText.Replace('%(NoneSubstituteText.Pattern2)', '%(NoneSubstituteText.Replacement2)'))</_ReplacementText>
2022

2123
<_CopyToOutputDirectory Condition="'%(NoneSubstituteText.CopyToOutputDirectory)' != ''">%(NoneSubstituteText.CopyToOutputDirectory)</_CopyToOutputDirectory>
2224
<_CopyToOutputDirectory Condition="'%(NoneSubstituteText.CopyToOutputDirectory)' == ''">Never</_CopyToOutputDirectory>
25+
26+
<_IncludeInVsix>false</_IncludeInVsix>
27+
<_IncludeInVsix Condition="'%(NoneSubstituteText.IncludeInVsix)' == 'true'">true</_IncludeInVsix>
2328
</PropertyGroup>
2429

2530
<MakeDir Directories="$(IntermediateOutputPath)"
2631
Condition="!Exists('$(IntermediateOutputPath)')" />
2732
<WriteLinesToFile File="$(__TargetFilePath)" Lines="$(_ReplacementText)" Overwrite="true" WriteOnlyWhenDifferent="true" />
2833

29-
<!-- Make sure it will get cleaned -->
30-
<ItemGroup >
34+
<ItemGroup>
3135
<None Include="$(__TargetFilePath)" CopyToOutputDirectory="$(_CopyToOutputDirectory)" />
3236
<FileWrites Include="$(__TargetFilePath)" Condition="'$(__TargetFileName)' != 'App.config'" />
37+
<Content Include="$(__TargetFilePath)" CopyToOutputDirectory="Always" IncludeInVsix="true" Link="$(__TargetLink)" Condition="'$(_IncludeInVsix)'=='true'" />
3338
</ItemGroup>
3439
</Target>
3540

@@ -61,4 +66,27 @@
6166
</ItemGroup>
6267
</Target>
6368

69+
<Target Name="BeforeResGen"
70+
Inputs="@(EmbeddedResource->'$(IntermediateOutputPath)%(Filename)%(Extension)')"
71+
Outputs="@(EmbeddedResource->'$(IntermediateOutputPath)resources\%(Filename)%(Extension)')"
72+
DependsOnTargets="CopyVsixResources"
73+
Condition="'$(Configuration)' != 'Proto' and '$(Language)'=='F#' and '$(DisableCompilerRedirection)' != 'true' ">
74+
75+
<SubstituteText EmbeddedResources="@(EmbeddedResource)">
76+
<Output TaskParameter="CopiedFiles" ItemName="CopiedFiles" />
77+
</SubstituteText>
78+
79+
<ItemGroup>
80+
<EmbeddedResource Remove="@(EmbeddedResource)"/>
81+
<EmbeddedResource Include="@(CopiedFiles)"/>
82+
</ItemGroup>
83+
84+
<MakeDir Directories="$(IntermediateOutputPath)" Condition="!Exists('$(IntermediateOutputPath)')" />
85+
<MakeDir Directories="$(IntermediateOutputPath)resources\" Condition="!Exists('$(IntermediateOutputPath)resources\')" />
86+
</Target>
87+
88+
<Target Name="CopyVsixResources">
89+
<Copy SourceFiles="@(CopyVsixResources)" DestinationFolder="$(IntermediateOutputPath)\resources\Resources" />
90+
</Target>
91+
6492
</Project>

FSharpTests.Directory.Build.props

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,18 @@
2222
<FscToolPath>$([System.IO.Path]::GetDirectoryName('$(DOTNET_HOST_PATH)'))</FscToolPath>
2323
<FscToolExe Condition="'$(OS)' != 'Unix'">dotnet.exe</FscToolExe>
2424
<FscToolExe Condition="'$(OS)' == 'Unix'">dotnet</FscToolExe>
25-
<DotnetFscCompilerPath>$(MSBuildThisFileDirectory)artifacts\bin\fsc\$(Configuration)\netcoreapp2.1\fsc.exe</DotnetFscCompilerPath>
25+
<DotnetFscCompilerPath>$(MSBuildThisFileDirectory)artifacts\bin\fsc\$(Configuration)\netcoreapp3.0\fsc.exe</DotnetFscCompilerPath>
2626

2727
<FsiToolPath>$([System.IO.Path]::GetDirectoryName('$(DOTNET_HOST_PATH)'))</FsiToolPath>
2828
<FsiToolExe Condition="'$(OS)' != 'Unix'">dotnet.exe</FsiToolExe>
2929
<FsiToolExe Condition="'$(OS)' == 'Unix'">dotnet</FsiToolExe>
30-
<DotnetFsiCompilerPath>$(MSBuildThisFileDirectory)artifacts\bin\fsi\$(Configuration)\netcoreapp2.1\fsi.exe</DotnetFsiCompilerPath>
30+
<DotnetFsiCompilerPath>$(MSBuildThisFileDirectory)artifacts\bin\fsi\$(Configuration)\netcoreapp3.0\fsi.exe</DotnetFsiCompilerPath>
3131
</PropertyGroup>
3232

3333
<!-- SDK targets override -->
3434
<PropertyGroup>
3535
<_FSharpBuildTargetFramework Condition="'$(MSBuildRuntimeType)'!='Core'">net472</_FSharpBuildTargetFramework>
36-
<_FSharpBuildTargetFramework Condition="'$(MSBuildRuntimeType)'=='Core'">netcoreapp2.1</_FSharpBuildTargetFramework>
36+
<_FSharpBuildTargetFramework Condition="'$(MSBuildRuntimeType)'=='Core'">netcoreapp3.0</_FSharpBuildTargetFramework>
3737
<_FSharpBuildBinPath>$(MSBuildThisFileDirectory)artifacts\bin\fsc\$(Configuration)\$(_FSharpBuildTargetFramework)</_FSharpBuildBinPath>
3838

3939
<FSharpBuildAssemblyFile>$(_FSharpBuildBinPath)\FSharp.Build.dll</FSharpBuildAssemblyFile>

INTERNAL.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ near the bottom of the build under the title 'Insert into VS'. Examine the log
4343
bottom you'll see a line that looks like `Created request #xxxxxx at https://...`.
4444

4545
To see all insertions created this way (possibly including for other internal teams), check
46-
[here](https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequests?creatorId=122d5278-3e55-4868-9d40-1e28c2515fc4&_a=active).
46+
[here](https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequests?createdBy=122d5278-3e55-4868-9d40-1e28c2515fc4&_a=active).
4747

4848
## Less interesting links
4949

NuGet.config

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<packageSources>
88
<clear />
99
<add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" />
10+
<add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
1011
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
1112
<add key="fsharp-daily" value="https://www.myget.org/F/fsharp-daily/api/v3/index.json" />
1213
<add key="roslyn-master-nightly" value="https://dotnet.myget.org/F/roslyn-master-nightly/api/v3/index.json" />

eng/Build.ps1

+25-13
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ param (
5050
[switch]$testCompiler,
5151
[switch]$testFSharpCore,
5252
[switch]$testFSharpQA,
53+
[switch]$testScripting,
5354
[switch]$testVs,
5455
[switch]$testAll,
5556
[string]$officialSkipTests = "false",
@@ -59,6 +60,8 @@ param (
5960

6061
Set-StrictMode -version 2.0
6162
$ErrorActionPreference = "Stop"
63+
$BuildCategory = ""
64+
$BuildMessage = ""
6265

6366
function Print-Usage() {
6467
Write-Host "Common settings:"
@@ -86,6 +89,7 @@ function Print-Usage() {
8689
Write-Host " -testCoreClr Run tests against CoreCLR"
8790
Write-Host " -testFSharpCore Run FSharpCore unit tests"
8891
Write-Host " -testFSharpQA Run F# Cambridge tests"
92+
Write-Host " -testScripting Run Scripting tests"
8993
Write-Host " -testVs Run F# editor unit tests"
9094
Write-Host " -officialSkipTests <bool> Set to 'true' to skip running tests"
9195
Write-Host ""
@@ -148,11 +152,11 @@ function Process-Arguments() {
148152

149153
function Update-Arguments() {
150154
if ($script:noVisualStudio) {
151-
$script:bootstrapTfm = "netcoreapp2.1"
155+
$script:bootstrapTfm = "netcoreapp3.0"
152156
$script:msbuildEngine = "dotnet"
153157
}
154158

155-
if ($bootstrapTfm -eq "netcoreapp2.1") {
159+
if ($bootstrapTfm -eq "netcoreapp3.0") {
156160
if (-Not (Test-Path "$ArtifactsDir\Bootstrap\fsc\fsc.runtimeconfig.json")) {
157161
$script:bootstrap = $True
158162
}
@@ -216,7 +220,7 @@ function UpdatePath() {
216220
TestAndAddToPath $subdir
217221

218222
# add windows SDK dir for ildasm.exe
219-
foreach ($child in Get-ChildItem "${env:ProgramFiles(x86)}\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.?.? Tools") {
223+
foreach ($child in Get-ChildItem "${env:ProgramFiles(x86)}\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.* Tools") {
220224
$subdir = $child
221225
}
222226
TestAndAddToPath $subdir
@@ -256,7 +260,7 @@ function TestUsingNUnit([string] $testProject, [string] $targetFramework) {
256260
}
257261

258262
function BuildCompiler() {
259-
if ($bootstrapTfm -eq "netcoreapp2.1") {
263+
if ($bootstrapTfm -eq "netcoreapp3.0") {
260264
$dotnetPath = InitializeDotNetCli
261265
$dotnetExe = Join-Path $dotnetPath "dotnet.exe"
262266
$fscProject = "$RepoRoot\src\fsharp\fsc\fsc.fsproj"
@@ -265,10 +269,10 @@ function BuildCompiler() {
265269
$argNoRestore = if ($norestore) { " --no-restore" } else { "" }
266270
$argNoIncremental = if ($rebuild) { " --no-incremental" } else { "" }
267271

268-
$args = "build $fscProject -c $configuration -v $verbosity -f netcoreapp2.1" + $argNoRestore + $argNoIncremental
272+
$args = "build $fscProject -c $configuration -v $verbosity -f netcoreapp3.0" + $argNoRestore + $argNoIncremental
269273
Exec-Console $dotnetExe $args
270274

271-
$args = "build $fsiProject -c $configuration -v $verbosity -f netcoreapp2.1" + $argNoRestore + $argNoIncremental
275+
$args = "build $fsiProject -c $configuration -v $verbosity -f netcoreapp3.0" + $argNoRestore + $argNoIncremental
272276
Exec-Console $dotnetExe $args
273277
}
274278
}
@@ -298,6 +302,9 @@ function EnablePreviewSdks() {
298302
}
299303

300304
try {
305+
$script:BuildCategory = "Build"
306+
$script:BuildMessage = "Failure preparing build"
307+
301308
Process-Arguments
302309

303310
. (Join-Path $PSScriptRoot "build-utils.ps1")
@@ -309,17 +316,14 @@ try {
309316
if ($ci) {
310317
Prepare-TempDir
311318
EnablePreviewSdks
312-
313-
# enable us to build netcoreapp2.1 product binaries
314-
$global:_DotNetInstallDir = Join-Path $RepoRoot ".dotnet"
315-
InstallDotNetSdk $global:_DotNetInstallDir $GlobalJson.tools.dotnet
316-
InstallDotNetSdk $global:_DotNetInstallDir "2.1.503"
317319
}
318320

319321
if ($bootstrap) {
322+
$script:BuildMessage = "Failure building bootstrap compiler"
320323
$bootstrapDir = Make-BootstrapBuild
321324
}
322325

326+
$script:BuildMessage = "Failure building product"
323327
if ($restore -or $build -or $rebuild -or $pack -or $sign -or $publish) {
324328
if ($noVisualStudio) {
325329
BuildCompiler
@@ -332,12 +336,13 @@ try {
332336
VerifyAssemblyVersionsAndSymbols
333337
}
334338

339+
$script:BuildCategory = "Test"
340+
$script:BuildMessage = "Failure running tests"
335341
$desktopTargetFramework = "net472"
336342
$coreclrTargetFramework = "netcoreapp3.0"
337343

338344
if ($testDesktop -and -not $noVisualStudio) {
339345
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.UnitTests\FSharp.Compiler.UnitTests.fsproj" -targetFramework $desktopTargetFramework
340-
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.LanguageServer.UnitTests\FSharp.Compiler.LanguageServer.UnitTests.fsproj" -targetFramework $desktopTargetFramework
341346
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.Private.Scripting.UnitTests\FSharp.Compiler.Private.Scripting.UnitTests.fsproj" -targetFramework $desktopTargetFramework
342347
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Build.UnitTests\FSharp.Build.UnitTests.fsproj" -targetFramework $desktopTargetFramework
343348
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Core.UnitTests\FSharp.Core.UnitTests.fsproj" -targetFramework $desktopTargetFramework
@@ -346,7 +351,6 @@ try {
346351

347352
if ($testCoreClr) {
348353
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.UnitTests\FSharp.Compiler.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
349-
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.LanguageServer.UnitTests\FSharp.Compiler.LanguageServer.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
350354
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.Private.Scripting.UnitTests\FSharp.Compiler.Private.Scripting.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
351355
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Build.UnitTests\FSharp.Build.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
352356
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Core.UnitTests\FSharp.Core.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
@@ -394,6 +398,13 @@ try {
394398
TestUsingNUnit -testProject "$RepoRoot\tests\fsharp\FSharpSuite.Tests.fsproj" -targetFramework $coreclrTargetFramework
395399
}
396400

401+
if ($testScripting) {
402+
if (-not $noVisualStudio) {
403+
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.Private.Scripting.UnitTests\FSharp.Compiler.Private.Scripting.UnitTests.fsproj" -targetFramework $desktopTargetFramework
404+
}
405+
TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.Private.Scripting.UnitTests\FSharp.Compiler.Private.Scripting.UnitTests.fsproj" -targetFramework $coreclrTargetFramework
406+
}
407+
397408
if ($testVs -and -not $noVisualStudio) {
398409
TestUsingNUnit -testProject "$RepoRoot\vsintegration\tests\GetTypesVS.UnitTests\GetTypesVS.UnitTests.fsproj" -targetFramework $desktopTargetFramework
399410
TestUsingNUnit -testProject "$RepoRoot\vsintegration\tests\UnitTests\VisualFSharp.UnitTests.fsproj" -targetFramework $desktopTargetFramework
@@ -405,6 +416,7 @@ catch {
405416
Write-Host $_
406417
Write-Host $_.Exception
407418
Write-Host $_.ScriptStackTrace
419+
Write-PipelineTelemetryError -Category $script:BuildCategory -Message $script:BuildMessage
408420
ExitWithExitCode 1
409421
}
410422
finally {

eng/Version.Details.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
<ProductDependencies>
44
</ProductDependencies>
55
<ToolsetDependencies>
6-
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.19603.17">
6+
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.20057.5">
77
<Uri>https://github.com/dotnet/arcade</Uri>
8-
<Sha>b902fd6b6948e689a5128fa6d94dc7de13e6af84</Sha>
8+
<Sha>d0833c8e5e58cfc507ce3c8da364e55931190263</Sha>
99
</Dependency>
1010
</ToolsetDependencies>
1111
</Dependencies>

eng/Versions.props

+7-4
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
</PropertyGroup>
2525
<PropertyGroup>
2626
<FSPackageMajorVersion>10.7</FSPackageMajorVersion>
27-
<FSPackageVersion>$(FSPackageMajorVersion).0</FSPackageVersion>
27+
<FSPackageVersion>$(FSPackageMajorVersion).1</FSPackageVersion>
2828
<FSProductVersionPrefix>$(FSPackageVersion)</FSProductVersionPrefix>
2929
<FSProductVersion>$(FSPackageVersion).0</FSProductVersion>
3030
</PropertyGroup>
@@ -68,13 +68,14 @@
6868
<!-- System.* packages -->
6969
<SystemCollectionsImmutableVersion>1.5.0</SystemCollectionsImmutableVersion>
7070
<SystemConsoleVersion>4.3.0</SystemConsoleVersion>
71+
<SystemDataSqlClientPackageVersion>4.3.0</SystemDataSqlClientPackageVersion>
7172
<SystemDesignVersion>4.0.0</SystemDesignVersion>
7273
<SystemDiagnosticsProcessVersion>4.3.0</SystemDiagnosticsProcessVersion>
7374
<SystemDiagnosticsTraceSourceVersion>4.3.0</SystemDiagnosticsTraceSourceVersion>
7475
<SystemIoCompressionVersion>4.3.0</SystemIoCompressionVersion>
7576
<SystemLinqExpressionsVersion>4.3.0</SystemLinqExpressionsVersion>
7677
<SystemLinqQueryableVersion>4.3.0</SystemLinqQueryableVersion>
77-
<SystemMemoryVersion>4.5.2</SystemMemoryVersion>
78+
<SystemMemoryVersion>4.5.3</SystemMemoryVersion>
7879
<SystemNetRequestsVersion>4.3.0</SystemNetRequestsVersion>
7980
<SystemNetSecurityVersion>4.3.0</SystemNetSecurityVersion>
8081
<SystemReflectionEmitVersion>4.3.0</SystemReflectionEmitVersion>
@@ -88,10 +89,13 @@
8889
<SystemSecurityClaimsVersion>4.3.0</SystemSecurityClaimsVersion>
8990
<SystemSecurityCryptographyAlgorithmsVersion>4.3.0</SystemSecurityCryptographyAlgorithmsVersion>
9091
<SystemSecurityPrincipalVersion>4.3.0</SystemSecurityPrincipalVersion>
92+
<SystemThreadingTasksDataflowPackageVersion>4.6.0</SystemThreadingTasksDataflowPackageVersion>
9193
<SystemThreadingTasksParallelVersion>4.3.0</SystemThreadingTasksParallelVersion>
94+
<SystemThreadingTasksDataflow>4.11.0</SystemThreadingTasksDataflow>
9295
<SystemThreadingThreadVersion>4.3.0</SystemThreadingThreadVersion>
9396
<SystemThreadingThreadPoolVersion>4.3.0</SystemThreadingThreadPoolVersion>
9497
<SystemValueTupleVersion>4.5.0</SystemValueTupleVersion>
98+
<SystemBuffersVersion>4.5.0</SystemBuffersVersion>
9599
<!-- Roslyn packages -->
96100
<MicrosoftCodeAnalysisEditorFeaturesVersion>$(RoslynVersion)</MicrosoftCodeAnalysisEditorFeaturesVersion>
97101
<MicrosoftCodeAnalysisEditorFeaturesTextVersion>$(RoslynVersion)</MicrosoftCodeAnalysisEditorFeaturesTextVersion>
@@ -102,7 +106,7 @@
102106
<MicrosoftCodeAnalysisTestResourcesProprietaryVersion>2.0.17</MicrosoftCodeAnalysisTestResourcesProprietaryVersion>
103107
<MicrosoftVisualStudioLanguageServicesVersion>$(RoslynVersion)</MicrosoftVisualStudioLanguageServicesVersion>
104108
<!-- Microsoft Build packages -->
105-
<MicrosoftBuildOverallPackagesVersion>16.0.461</MicrosoftBuildOverallPackagesVersion>
109+
<MicrosoftBuildOverallPackagesVersion>16.4</MicrosoftBuildOverallPackagesVersion>
106110
<MicrosoftBuildVersion>$(MicrosoftBuildOverallPackagesVersion)</MicrosoftBuildVersion>
107111
<MicrosoftBuildFrameworkVersion>$(MicrosoftBuildOverallPackagesVersion)</MicrosoftBuildFrameworkVersion>
108112
<MicrosoftBuildTasksCoreVersion>$(MicrosoftBuildOverallPackagesVersion)</MicrosoftBuildTasksCoreVersion>
@@ -118,7 +122,6 @@
118122
<MicrosoftVisualStudioGraphModelVersion>16.0.28226-alpha</MicrosoftVisualStudioGraphModelVersion>
119123
<MicrosoftVisualStudioImageCatalogVersion>16.1.28916.169</MicrosoftVisualStudioImageCatalogVersion>
120124
<MicrosoftVisualStudioImagingVersion>16.1.28917.181</MicrosoftVisualStudioImagingVersion>
121-
<MicrosoftVisualStudioLanguageServerClientVersion>16.1.3121</MicrosoftVisualStudioLanguageServerClientVersion>
122125
<MicrosoftVisualStudioLanguageStandardClassificationVersion>16.1.89</MicrosoftVisualStudioLanguageStandardClassificationVersion>
123126
<MicrosoftVisualStudioLanguageVersion>16.1.89</MicrosoftVisualStudioLanguageVersion>
124127
<MicrosoftVisualStudioLanguageIntellisenseVersion>16.1.89</MicrosoftVisualStudioLanguageIntellisenseVersion>

eng/build-utils.ps1

+3-3
Original file line numberDiff line numberDiff line change
@@ -238,9 +238,9 @@ function Make-BootstrapBuild() {
238238

239239
# prepare FsLex and Fsyacc and AssemblyCheck
240240
Run-MSBuild "$RepoRoot\src\buildtools\buildtools.proj" "/restore /t:Publish /p:PublishWindowsPdb=false" -logFileName "BuildTools" -configuration $bootstrapConfiguration
241-
Copy-Item "$ArtifactsDir\bin\fslex\$bootstrapConfiguration\netcoreapp2.1\publish" -Destination "$dir\fslex" -Force -Recurse
242-
Copy-Item "$ArtifactsDir\bin\fsyacc\$bootstrapConfiguration\netcoreapp2.1\publish" -Destination "$dir\fsyacc" -Force -Recurse
243-
Copy-Item "$ArtifactsDir\bin\AssemblyCheck\$bootstrapConfiguration\netcoreapp2.1\publish" -Destination "$dir\AssemblyCheck" -Force -Recurse
241+
Copy-Item "$ArtifactsDir\bin\fslex\$bootstrapConfiguration\netcoreapp3.0\publish" -Destination "$dir\fslex" -Force -Recurse
242+
Copy-Item "$ArtifactsDir\bin\fsyacc\$bootstrapConfiguration\netcoreapp3.0\publish" -Destination "$dir\fsyacc" -Force -Recurse
243+
Copy-Item "$ArtifactsDir\bin\AssemblyCheck\$bootstrapConfiguration\netcoreapp3.0\publish" -Destination "$dir\AssemblyCheck" -Force -Recurse
244244

245245
# prepare compiler
246246
$projectPath = "$RepoRoot\proto.proj"

0 commit comments

Comments
 (0)