Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the dispatch internal state from the immutable Dispatch object #57

Open
llucax opened this issue Sep 25, 2024 · 1 comment
Open
Labels
part:actor Affects the dispatching actor part:dispatcher Affects the high-level dispatcher interface type:tech-debt Improves the project without visible changes for users

Comments

@llucax
Copy link
Contributor

llucax commented Sep 25, 2024

Since the Dispatch's deleted bool and running_state_change_synced are only attached as mutable properties for internal state tracking, it might make more sense to separate the state from the immutable dispatch, and have a DispatchState mutable class and a separate dict to map dispatch ID to its state, for example.

You can pass the state object to the Dispatch constructor and store it as a private property and expose read-only properties to access the state, if it needs to be accessed externally, and store the dict and mutate it from this actor only.

Originally posted by @llucax in #54 (comment)

@llucax llucax added type:tech-debt Improves the project without visible changes for users part:actor Affects the dispatching actor part:dispatcher Affects the high-level dispatcher interface labels Sep 25, 2024
@Marenz
Copy link
Contributor

Marenz commented Dec 19, 2024

in #82 running_state_change_synced was removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:actor Affects the dispatching actor part:dispatcher Affects the high-level dispatcher interface type:tech-debt Improves the project without visible changes for users
Projects
None yet
Development

No branches or pull requests

2 participants