Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert AioRpcErrors to the appropriate base-client exception before re-raising #77

Open
shsms opened this issue Dec 3, 2024 · 0 comments
Open

Convert AioRpcErrors to the appropriate base-client exception before re-raising #77

shsms opened this issue Dec 3, 2024 · 0 comments
Assignees
@shsms
Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users

Comments

@shsms
Copy link
Contributor

shsms commented Dec 3, 2024

What's needed?

Currently, the client doesn't appear to be handling the AioRpcError exceptions raised by the grpc client, which leaks the underlying exceptions to the client's users.

Proposed solution

We need to pass the caught AioRpcErrors to ApiClientError.from_grpc_error method and raise those.

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response
@shsms shsms added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users labels Dec 3, 2024
@shsms shsms self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shsms shsms

Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shsms