Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total 3-phase AC current metric is ambiguous #7

Open
tiyash-basu-frequenz opened this issue Aug 31, 2022 · 1 comment
Open

Total 3-phase AC current metric is ambiguous #7

tiyash-basu-frequenz opened this issue Aug 31, 2022 · 1 comment
Labels
part:protobuf Affects the protocol buffer definition files priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working
Milestone

Comments

@tiyash-basu-frequenz
Copy link
Contributor

What happened?

Per-phase AC currents can be aggregated in two different ways:
a. scalar addition
b. vector addition

The results of these two additions can differ. E.g., if the current on each phase is 16A, then the scalar sum would be 42A, but the vector sum would be 0A (assuming the phases are exactly 120 degrees apart).

The total 3-phase current metric in the AC message is ambiguous, because does not specify whether it was calculated using scalar addition or vector addition. If still used, this could lead to errors in client applications.

What did you expect instead?

The total 3-phase current should be removed from AC metrics. If aggregating the current values in the three phases is required, clients can do it themselves, based upon their respective use-cases.

Affected version(s)

v0.10.x (version:0.10.x)

Affected part(s)

Protocol buffer definition (part:protobuf)

Extra information

No response

@tiyash-basu-frequenz tiyash-basu-frequenz added priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working labels Aug 31, 2022
@keywordlabeler keywordlabeler bot added part:protobuf Affects the protocol buffer definition files version:0.10.x labels Aug 31, 2022
@tiyash-basu-frequenz tiyash-basu-frequenz added this to the Untriaged milestone Aug 8, 2023
@tiyash-basu-frequenz
Copy link
Contributor Author

tiyash-basu-frequenz commented May 14, 2024

What we can do as an intermediate solution is to

  • always provide a scalar sum of the 3-phase currents from the API service
  • and guarantee it in the API specs by documenting the above wherever required, e.g., here and here.

@tiyash-basu-frequenz tiyash-basu-frequenz modified the milestones: Backlog, v0.17.1 May 14, 2024
@tiyash-basu-frequenz tiyash-basu-frequenz modified the milestones: v0.17.1, Backlog Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:protobuf Affects the protocol buffer definition files priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants