Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VARIANTS don't need to be in shared memory #50

Open
EJP286CRSKW opened this issue Dec 19, 2023 · 5 comments
Open

VARIANTS don't need to be in shared memory #50

EJP286CRSKW opened this issue Dec 19, 2023 · 5 comments

Comments

@EJP286CRSKW
Copy link

The JNI part of Dispatch.invokev() allocates shared memory for the array of VARIANTS.

I have determined experimentally that this is not necessary, testing about 500 different Excel APIs, having first noted that none of the Microsoft example code uses shared memory either.

It would therefore be a lot simpler to use a std::vector, which would also simplify the deallocation process on exit, which is presently missed, and therefore leaked, in a number of presently unchecked error cases.

@freemansoft
Copy link
Owner

code examples.

The only way to get changes is to submit a PR.

@EJP286CRSKW
Copy link
Author

EJP286CRSKW commented Mar 18, 2024

I have a substantially rewritten version of Dispatch.cpp and a couple of other .cpp files which I will submit with test cases when next I get back to Jacob.

I thought this was a PR?

@freemansoft
Copy link
Owner

A Pull Request is code that is intended to merge with the source tree from your repository. You've provided suggestions which I appreciate but are a bunch of work because they don't include any tests.

I picked up several of your changes tonight. VSCode reformatted any file I touched. In addition, I moved the source files all into /src from where they were on the top level. The source organization should have moved more to the maven style standard years ago.

@EJP286CRSKW
Copy link
Author

OK. I am no Git guy but I'll see what I can do.

@freemansoft
Copy link
Owner

I can work with a set of files. The hard ones are "here a couple changes in 4 different files"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants