-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VARIANTS don't need to be in shared memory #50
Comments
code examples. The only way to get changes is to submit a PR. |
I have a substantially rewritten version of Dispatch.cpp and a couple of other .cpp files which I will submit with test cases when next I get back to Jacob. I thought this was a PR? |
A Pull Request is code that is intended to merge with the source tree from your repository. You've provided suggestions which I appreciate but are a bunch of work because they don't include any tests. I picked up several of your changes tonight. VSCode reformatted any file I touched. In addition, I moved the source files all into /src from where they were on the top level. The source organization should have moved more to the maven style standard years ago. |
OK. I am no Git guy but I'll see what I can do. |
I can work with a set of files. The hard ones are "here a couple changes in 4 different files" |
The JNI part of Dispatch.invokev() allocates shared memory for the array of VARIANTS.
I have determined experimentally that this is not necessary, testing about 500 different Excel APIs, having first noted that none of the Microsoft example code uses shared memory either.
It would therefore be a lot simpler to use a std::vector, which would also simplify the deallocation process on exit, which is presently missed, and therefore leaked, in a number of presently unchecked error cases.
The text was updated successfully, but these errors were encountered: