Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor page content into components #277

Open
GuillermoFloresV opened this issue Mar 26, 2023 · 0 comments
Open

Refactor page content into components #277

GuillermoFloresV opened this issue Mar 26, 2023 · 0 comments

Comments

@GuillermoFloresV
Copy link
Member

Describe the issue
When running tests, we need to be able to test them independently. Currently, when we are running tests to render a page we need to check if a session exists which is not what the test is for. Because of this, we should make a component for our main content on each page where you don't need to log in to view the content (index, join, etc) since they should all independently be able to render without a session.

To Reproduce
Steps to reproduce the behavior:

  1. Go to /pages tests.
  2. Delete the mock session inside the test
  3. The test will fail due to a lack of a session even though we only want to render some HTML.

Expected behavior
Pages should be able to render correctly regardless of if a session exists or not. Making components should allow us to do this since it gives us greater control over what we can test by making everything independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant