Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CORS issue on Firefox when attempting to join classroom #141

Open
GuillermoFloresV opened this issue Oct 9, 2022 · 0 comments
Open

Comments

@GuillermoFloresV
Copy link
Member

GuillermoFloresV commented Oct 9, 2022

Describe the bug
The bug has been temporarily patched with this commit: 40e7ab1

However, this is a temp fix as we should look into why there is a CORS issue when using this API on Firefox. The issue does not appear on Chrome and has not been tested on Microsoft Edge.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '/pages/join/[...joincode].js'
  2. Remove/comment out event.preventDefault()
  3. Attempt to invite someone to the classroom
  4. See error (TypeError: NetworkError when attempting to fetch resource)

Additional context

The bug is currently patched, but we should look into the underlying cause to fix it without bypassing CORS the way we did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant