While studying the KNX protocol I was looking through your code and noticed that you do not distinguish between individual and group addressing. You do so in your debugging output, but not while handling telegrams.
Shouldn't you be checking the target address type bit before comparing against configured group addresses here?
|
if(IsAddressAssigned(telegram.GetTargetAddress(), addressedComObjectIndex)) |
It probably doesn't matter as this would only collide in installations with sufficient KNX modules, not your average hobby environment.
Thanks in any case for providing the code! Very interesting stuff!
While studying the KNX protocol I was looking through your code and noticed that you do not distinguish between individual and group addressing. You do so in your debugging output, but not while handling telegrams.
Shouldn't you be checking the target address type bit before comparing against configured group addresses here?
KnxDevice/KnxTpUart.cpp
Line 404 in b9b0d87
It probably doesn't matter as this would only collide in installations with sufficient KNX modules, not your average hobby environment.
Thanks in any case for providing the code! Very interesting stuff!