fix: Convoy should respond with a 413 for oversized payloads #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BolajiOlajide
commented
Jul 20, 2024
BolajiOlajide
force-pushed
the
bo/properly-handle-oversized-payloads
branch
from
dcab495 to
99eadea
Compare
jirevwe
approved these changes
Jul 23, 2024
danvixent
approved these changes
Jul 24, 2024
Oluwadaminiola
pushed a commit
that referenced
this pull request
Oct 1, 2024
* respect MaxResponseSize when ingesting payload * add tests * change check point * add shebang to script * add max ingest size to default project * debug tests * more debugging * fix failing tests * add debug vars * use previous method for creating request body * remove verbosity from tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2094
This ensures the
ingestendpoint always respect the max size accepted for payloads.