Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report]: Convoy should respond with a 413 for oversized payloads #2094

Closed
systembell opened this issue Jul 17, 2024 · 1 comment · Fixed by #2095
Closed

[Bug report]: Convoy should respond with a 413 for oversized payloads #2094

systembell opened this issue Jul 17, 2024 · 1 comment · Fixed by #2095
Labels
bug Something isn't working

Comments

@systembell
Copy link

Describe the bug

There is a Convoy configuration setting max_response_size that limits the size of client requests sent to ingest, but when a client sends a payload that is too large, Convoy still responds with a 200.

To Reproduce

Steps to reproduce the behavior:

  1. Generate a sample payload larger than the configured max_response_size
  2. POST it to the Convoy subscription endpoint
  3. Convoy will respond with {"status":true,"message":"Event received","data":51200} and an http code of 200.

Expected behavior

Convoy would ideally respond with a 413 (Payload Too Large)

Stack (please complete the following information):

  • Convoy: v24.1.2
  • PostgreSQL: 15
  • Redis: 7
  • OS: Kubernetes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Convoy should respond with a 413 for oversized payloads BolajiOlajide/convoy
1 participant
@systembell