feat: Add support for inbound webhooks that use form data #1998
+119
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BolajiOlajide
commented
May 7, 2024
|
|
|
Shouldn't the JOSN payload received at the endpoint be this? {
"name": "legbegbe",
"error": "no error",
"status": "success"
} |
@jirevwe You're right. However, I did it that way because the return type of FormData is actually a map of the structure |
|
@jirevwe Updated.
|
jirevwe
approved these changes
May 22, 2024
|
It works but struggles with nested values. This curl -L -X POST 'http://localhost:5005/ingest/bRR0NEtU6sw0ZeD3' \
-H 'Authorization: Bearer CO.Ci4jlWTc4gJeWnXZ.NatfMfQM3Ks78Y3Ibm6XKqwCLS1eG35kNwcRe6jd42mOc0EdzBu5JCl9qZHJhSBE' \
-F 'endpoint_id="01HS16E631RTHZ2EN4K54ZFC9H"' \
-F 'data[event_type]="created"' \
-F 'data[name]="digital"' \
-F 'data[email]="[email protected]"' \
-F 'data[age]="10"' \
-F 'custom_headers[id]="2aff13ec-a373-4218-9fde-0c1328801291"' \
-F 'custom_headers[timestamp]="2024-03-20T06:56:06.991Z"' \
-F 'custom_headers[x-tenant-id]="xpi"' \
-F 'idempotency_key="test123"' \
-F 'event_type="created"'comes out as {
"data": {
"data[age]": "10",
"data[name]": "auxiliary",
"event_type": "created",
"data[email]": "[email protected]",
"endpoint_id": "01HS16E631RTHZ2EN4K54ZFC9H",
"idempotency_key": "test123",
"data[event_type]": "created",
"custom_headers[id]": "2aff13ec-a373-4218-9fde-0c1328801291",
"custom_headers[timestamp]": "2024-03-20T06:56:06.991Z",
"custom_headers[x-tenant-id]": "xpi"
},
"event_type": "created",
"endpoint_id": "01HS6EX2KC8FMN8NDTMNKQQN13",
"custom_headers": {
"header": "valve"
}
} |
|
Are you sure you're on the correct branch, I tried this using the same payload and I get this: |
|
@jirevwe Gentle nudge on this. :) |
danvixent
approved these changes
Jul 18, 2024
jirevwe
added a commit
that referenced
this pull request
Jul 22, 2024
* fix: fixed api migration bug (#2087) Co-authored-by: Raymond Tukpe <[email protected]> * chore: update changelog (#2093) * chore: update ui dependencies (#2097) * feat: Add support for inbound webhooks that use form data (#1998) * accept multipart/form-data content type during ingestion * change logic for handling form data * fix failing test * added e2e integration test suite (#2083) * added e2e broadcast integration test * updated e2e broadcast integration test * removed unneeded files * WIP: integrated convoy sdk * added direct event tests * added fan-out event tests * updated e2e tests * updated go version to 1.21 * revert retention policy * switched to agent cmd * updated tests * updated tests with negative scenarios * added integration test flag * removed pointer from chan * reverted typescript version change * use correct time for delivery attempt --------- Co-authored-by: Subomi Oluwalana <[email protected]> Co-authored-by: Raymond Tukpe <[email protected]> Co-authored-by: Bolaji Olajide <[email protected]> Co-authored-by: Smart Mekiliuwa <[email protected]>
Oluwadaminiola
pushed a commit
that referenced
this pull request
Oct 1, 2024
* accept multipart/form-data content type during ingestion * change logic for handling form data * fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1987
This PR adds support for inbound webhooks that send data via
form-data. It defaults toJSONwhen the content type isn'tmultipart/form-datato avoid introducing a breaking change. As time goes one, we'll want to add support forwww-url-encoded.