display user-settings page when there are no orgs #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oluwadaminiola
approved these changes
May 7, 2024
Oluwadaminiola
pushed a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1967
CleanShot.2024-05-07.at.02.43.51.mp4
I added a comment in the originating issue about how the logic for forcing users to create an organisation might not be in the best place. https://sourcegraph.com/github.com/frain-dev/convoy/-/blob/web/ui/dashboard/src/app/private/private.component.html?L100
Since the exception for displaying a page when there are no organisations only applies to the
/user-settingsroute, then we can get away with it with this band-aid fix.cc @subomi