-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Preview Environments for PRs — Uffizzi Integration #1305
Conversation
Hi, @jirevwe! Would love to get some help on this: Running this, what I'm seeing is all the containers come up, except one — the Seems to be an issue with mongo replication!? I did try increasing the Do let me know how it's looking and what changes I can make to make Uffizzi previews valuable for |
Hey @jirevwe Friendly ping - wondering if you were able to take a look at this? Would like to fix this and make Uffizzi previews serviceable and efficient for Convoy. Let me know :) |
Hi @ShrutiC-git, taking a look at the logs does seem like an issue with the mongo replica set. You can take a look at this file docker-compose.yml to see how we currently recommend setting up a Mongo replica set with Convoy along with an example of what the |
thanks, @Dotunj, taking a look ~ |
33229ec
to
c5d6d7a
Compare
hey @Dotunj, thanks again for your help on this. The example you sent was very helpful! cc @jirevwe So, all the containers do come up, and looking at the logs, it seems the The
Also, What is weird is I would randomly see a It'd load the sign-in screen. I'd log into the preview using the username The same request on retrying would serve the page successfully. Seeing this behavior also on the sign-in screen. Could it be a memory issue? The memory I have allotted to the services is rather on the higher side, but maybe it requires more. Since I'm not seeing this error constantly, The same request on refreshing serves the page, and vice-versa ( if the sign-in screen is serviceable, on refreshing, it'd throw a 503). This does indicate that it is not an issue with the configuration itself, but perhaps the Not sure what could be the issue. Could taking a look at the PoC PR help? How could we debug this more efficiently? Super glad we moved a few steps closer - the preview does come up and the containers seem healthy. Nothing obvious I could point to. Looking forward to making the final changes and having the previews serviceable and efficient! |
|
Fixes #1275
A WiP PR for Uffizzi Integration with Convoy.
This PR uses two GHA workflows —
uffizzi-build.yml
anduffizzi-preview.yml
— to build and provision preview environments.This PR uses
convoy's Dockerfile
to buildconvoy worker
,convoy scheduler
andconvoy web
from source, ensuring changes are reflected in the preview environment. These containers are defined in thedocker-compose.uffizzi.yml
file, which adds theUffizzi
integration toconvoy
. Other containers includeredis server
andreplica set Mongo servers (2 in total)
.Here is a test PR opened on my fork. The comment posted on the PR will take me to the preview.
Opening this draft PR to get some help on getting the previews functional and efficient for the
convoy
community.