Merge remote-tracking branch 'upstream/master' into feat/coverage-fuzz

Author: grandizzy

.github/PULL_REQUEST_TEMPLATE.md

@@ -3,8 +3,15 @@ Thank you for your Pull Request. Please provide a description above and review
 the requirements below.
 
 Bug fixes and new features should include tests.
+
+Contributors guide: https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md
+
+The contributors guide includes instructions for running rustfmt and building the
+documentation.
 -->
 
+<!-- ** Please select "Allow edits from maintainers" in the PR Options ** -->
+
 ## Motivation
 
 <!--
@@ -19,3 +26,9 @@ thought of as being the motivation for your change.
 Summarize the solution and provide any necessary context needed to understand
 the code change.
 -->
+
+## PR Checklist
+
+- [ ] Added Tests
+- [ ] Added Documentation
+- [ ] Breaking changes

.github/assets/banner.png

@@ -61,6 +61,6 @@
     "template": "${{CHANGELOG}}\n## Other\n\n${{UNCATEGORIZED}}\n## Full Changelog:\n ${{RELEASE_DIFF}}",
     "pr_template": "- ${{TITLE}} (#${{NUMBER}}) by @${{AUTHOR}}",
     "empty_template": "- No changes",
-    "max_pull_requests": 100,
-    "max_back_track_time_days": 60
+    "max_pull_requests": 500,
+    "max_back_track_time_days": 120
 }

.github/assets/build_benchmark_openzeppelin_dark.png

@@ -3,5 +3,5 @@ set -eo pipefail
 
 # We have to ignore at shell level because testdata/ is not a valid Foundry project,
 # so running `forge fmt` with `--root testdata` won't actually check anything
-shopt -s extglob
-cargo run --bin forge -- fmt "$@" $(find testdata -name '*.sol' ! -name Vm.sol)
+cargo run --bin forge -- fmt "$@" \
+    $(find testdata -name '*.sol' ! -name Vm.sol ! -name console.sol)

.github/assets/build_benchmark_openzeppelin_light.png

@@ -83,19 +83,19 @@ def __init__(
     ),
     Case(
         name="integration",
-        filter="kind(test) & !test(/issue|forge_std|ext_integration/)",
+        filter="kind(test) & !test(/\\b(issue|ext_integration)/)",
         n_partitions=3,
         pr_cross_platform=True,
     ),
     Case(
         name="integration / issue-repros",
-        filter="package(=forge) & test(~issue)",
+        filter="package(=forge) & test(/\\bissue/)",
         n_partitions=2,
         pr_cross_platform=False,
     ),
     Case(
         name="integration / external",
-        filter="package(=forge) & test(~ext_integration)",
+        filter="package(=forge) & test(/\\bext_integration/)",
         n_partitions=2,
         pr_cross_platform=False,
     ),

.github/assets/build_benchmark_solady_dark.png

@@ -1,11 +1,6 @@
 name: docker
 
 on:
-  push:
-    tags:
-      - "v*.*.*"
-  schedule:
-    - cron: "0 0 * * *"
   # Trigger without any parameters a proactive rebuild
   workflow_dispatch: {}
   workflow_call:
@@ -22,7 +17,7 @@ env:
 jobs:
   build:
     name: build and push
-    runs-on: Linux-20.04
+    runs-on: Linux-22.04
     permissions:
       id-token: write
       packages: write
@@ -34,7 +29,10 @@ jobs:
       - uses: Swatinem/rust-cache@v2
         with:
           cache-on-failure: true
-      - uses: taiki-e/install-action@cross
+      - name: Install cross
+        id: cross_main
+        run: |
+          cargo install cross
       # Login against a Docker registry except on PR
       # https://github.com/docker/login-action
       - name: Login into registry ${{ env.REGISTRY }}

.github/assets/build_benchmark_solady_light.png

@@ -15,6 +15,7 @@ concurrency:
 
 env:
   CARGO_TERM_COLOR: always
+  RUST_BACKTRACE: full
 
 jobs:
   matrices:
@@ -46,7 +47,7 @@ jobs:
       fail-fast: false
       matrix: ${{ fromJson(needs.matrices.outputs.test-matrix) }}
     env:
-      ETH_RPC_URL: https://eth-mainnet.alchemyapi.io/v2/C3JEvfW6VgtqZQa-Qp1E-2srEiIc02sD
+      ETH_RPC_URL: https://reth-ethereum.ithaca.xyz/rpc
       CARGO_PROFILE_DEV_DEBUG: 0
     steps:
       - uses: actions/checkout@v4
@@ -67,11 +68,11 @@ jobs:
         with:
           bun-version: latest
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.11
       - name: Install Vyper
-        run: pip install vyper~=0.4.0
+        run: pip --version && pip install vyper==0.4.0
 
       - name: Forge RPC cache
         uses: actions/cache@v3

.github/assets/demo.gif

@@ -4,15 +4,17 @@ on:
   push:
     tags:
       - "stable"
+      - "rc"
       - "v*.*.*"
   schedule:
-    - cron: "0 0 * * *"
+    - cron: "0 6 * * *"
   workflow_dispatch:
 
 env:
   CARGO_TERM_COLOR: always
   IS_NIGHTLY: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
   PROFILE: maxperf
+  STABLE_VERSION: "v0.3.0"
 
 jobs:
   prepare:
@@ -58,7 +60,7 @@ jobs:
         uses: mikepenz/release-changelog-builder-action@v4
         with:
           configuration: "./.github/changelog.json"
-          fromTag: ${{ env.IS_NIGHTLY == 'true' && 'nightly' || '' }}
+          fromTag: ${{ env.IS_NIGHTLY == 'true' && 'nightly' || env.STABLE_VERSION }}
           toTag: ${{ steps.release_info.outputs.tag_name }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -87,17 +89,29 @@ jobs:
           # `target`: Rust build target triple
           # `platform` and `arch`: Used in tarball names
           # `svm`: target platform to use for the Solc binary: https://github.com/roynalnaruto/svm-rs/blob/84cbe0ac705becabdc13168bae28a45ad2299749/svm-builds/build.rs#L4-L24
-          - runner: Linux-20.04
+          - runner: Linux-22.04
             target: x86_64-unknown-linux-gnu
             svm_target_platform: linux-amd64
             platform: linux
             arch: amd64
-          - runner: Linux-20.04
+          - runner: Linux-22.04
+            target: x86_64-unknown-linux-musl
+            svm_target_platform: linux-amd64
+            platform: alpine
+            arch: amd64
+          - runner: Linux-22.04
             target: aarch64-unknown-linux-gnu
             svm_target_platform: linux-aarch64
             platform: linux
             arch: arm64
-          - runner: macos-12-large
+          - runner: Linux-22.04
+            target: aarch64-unknown-linux-musl
+            svm_target_platform: linux-aarch64
+            platform: alpine
+            arch: arm64
+          # This is pinned to `macos-13-large` to support old SDK versions.
+          # If the runner is deprecated it should be pinned to the oldest available version of the runner.
+          - runner: macos-13-large
             target: x86_64-apple-darwin
             svm_target_platform: macosx-amd64
             platform: darwin
@@ -128,12 +142,10 @@ jobs:
           echo "SDKROOT=$(xcrun -sdk macosx --show-sdk-path)" >> $GITHUB_ENV
           echo "MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx --show-sdk-platform-version)" >> $GITHUB_ENV
 
-      - name: Linux ARM setup
-        if: matrix.target == 'aarch64-unknown-linux-gnu'
+      - name: cross setup
+        if: matrix.target == 'x86_64-unknown-linux-musl' || matrix.target == 'aarch64-unknown-linux-musl' || matrix.target == 'aarch64-unknown-linux-gnu'
         run: |
-          sudo apt-get update -y
-          sudo apt-get install -y gcc-aarch64-linux-gnu
-          echo "CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER=aarch64-linux-gnu-gcc" >> $GITHUB_ENV
+          cargo install cross
 
       - name: Build binaries
         env:
@@ -146,7 +158,7 @@ jobs:
         run: |
           set -eo pipefail
           flags=(--target $TARGET --profile $PROFILE --bins 
-            --no-default-features --features rustls,aws-kms,cli,asm-keccak)
+            --no-default-features --features aws-kms,cli,asm-keccak)
 
           # `jemalloc` is not fully supported on MSVC or aarch64 Linux.
           if [[ "$TARGET" != *msvc* && "$TARGET" != "aarch64-unknown-linux-gnu" ]]; then
@@ -155,7 +167,11 @@ jobs:
 
           [[ "$TARGET" == *windows* ]] && ext=".exe"
 
-          cargo build "${flags[@]}"
+          if [[ "$TARGET" == *-musl || "$TARGET" == "aarch64-unknown-linux-gnu" ]]; then
+            cross build "${flags[@]}"
+          else
+            cargo build "${flags[@]}"
+          fi
 
           bins=(anvil cast chisel forge)
           for name in "${bins[@]}"; do
@@ -177,7 +193,7 @@ jobs:
           ARCH: ${{ matrix.arch }}
         shell: bash
         run: |
-          if [ "$PLATFORM_NAME" == "linux" ]; then
+          if [[ "$PLATFORM_NAME" == "linux" || "$PLATFORM_NAME" == "alpine" ]]; then
             tar -czvf "foundry_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" -C $OUT_DIR forge cast anvil chisel
             echo "file_name=foundry_${VERSION_NAME}_${PLATFORM_NAME}_${ARCH}.tar.gz" >> $GITHUB_OUTPUT
           elif [ "$PLATFORM_NAME" == "darwin" ]; then

.github/changelog.json

@@ -12,6 +12,7 @@ concurrency:
 
 env:
   CARGO_TERM_COLOR: always
+  RUST_BACKTRACE: full
 
 jobs:
   nextest:
@@ -108,14 +109,10 @@ jobs:
       - uses: Swatinem/rust-cache@v2
         with:
           cache-on-failure: true
-      - run: cargo hack check
+      - run: cargo hack check --each-feature --exclude-features isolate-by-default
 
   deny:
     uses: ithacaxyz/ci/.github/workflows/deny.yml@main
-    with:
-      # Clear out arguments to not pass `--all-features` to `cargo deny`.
-      # Many crates have an `openssl` feature which enables banned dependencies.
-      deny-flags: ""
 
   ci-success:
     runs-on: ubuntu-latest