refactor: remove redundant .as_str() calls on temporary strings (#12279)

* Update serde_helpers.rs

* Update install.rs

* Update ext_integration.rs

* Update lib.rs

* Update script.rs

Author: Fallengirl

crates/common/src/serde_helpers.rs

@@ -63,7 +63,7 @@ impl NumberOrHexU256 {
     /// Tries to convert this into a [U256]].
     pub fn try_into_u256<E: de::Error>(self) -> Result<U256, E> {
         match self {
-            Self::Int(num) => U256::from_str(num.to_string().as_str()).map_err(E::custom),
+            Self::Int(num) => U256::from_str(&num.to_string()).map_err(E::custom),
             Self::Hex(val) => Ok(val),
         }
     }

crates/forge/src/cmd/install.rs

@@ -234,7 +234,7 @@ impl DependencyInstallOpts {
                         msg.push_str("\n\n");
 
                         if let Some(dep_id) = &dep_id {
-                            msg.push_str(dep_id.to_string().as_str());
+                            msg.push_str(&dep_id.to_string());
                         } else {
                             msg.push_str(tag);
                         }
@@ -252,7 +252,7 @@ impl DependencyInstallOpts {
                 msg.push(' ');
 
                 if let Some(dep_id) = dep_id {
-                    msg.push_str(dep_id.to_string().as_str());
+                    msg.push_str(&dep_id.to_string());
                 } else {
                     msg.push_str(tag.as_str());
                 }

crates/forge/tests/cli/ext_integration.rs

@@ -44,7 +44,7 @@ fn sablier_v2_core() {
             // Skip fork tests.
             .args(["--nmc", "Fork"])
             // Increase the gas limit: https://github.com/sablier-labs/v2-core/issues/956
-            .args(["--gas-limit", u64::MAX.to_string().as_str()])
+            .args(["--gas-limit", &u64::MAX.to_string()])
             // Run tests without optimizations.
             .env("FOUNDRY_PROFILE", "lite")
             .install_command(&["bun", "install", "--prefer-offline"])

crates/script/src/lib.rs

@@ -709,7 +709,7 @@ mod tests {
             "0x4e59b44847b379578588920ca78fbf26c0b4956c",
             "--unlocked",
             "--private-key",
-            key.to_string().as_str(),
+            &key.to_string(),
         ]);
         assert!(args.is_err());
     }

crates/test-utils/src/script.rs

@@ -158,15 +158,15 @@ impl ScriptTester {
 
     /// Adds given address as sender
     pub fn sender(&mut self, addr: Address) -> &mut Self {
-        self.args(&["--sender", addr.to_string().as_str()])
+        self.args(&["--sender", &addr.to_string()])
     }
 
     pub fn add_sig(&mut self, contract_name: &str, sig: &str) -> &mut Self {
         self.args(&["--tc", contract_name, "--sig", sig])
     }
 
     pub fn add_create2_deployer(&mut self, create2_deployer: Address) -> &mut Self {
-        self.args(&["--create2-deployer", create2_deployer.to_string().as_str()])
+        self.args(&["--create2-deployer", &create2_deployer.to_string()])
     }
 
     /// Adds the `--unlocked` flag