Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BLE won't work on Android 11 and below #968

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

kienvo
Copy link
Member

@kienvo kienvo commented Jul 5, 2024

Fixes #957

Changes:

Had been tested on Android 10.

@kienvo kienvo requested review from mariobehling and adityastic July 5, 2024 05:05
@kienvo
Copy link
Member Author

kienvo commented Jul 5, 2024

The pipeline failed as described at #969

@mariobehling
Copy link
Member

@kienvo The CI is failing. Could you check, please?

@kienvo
Copy link
Member Author

kienvo commented Jul 6, 2024

@kienvo The CI is failing. Could you check, please?

It's failing because of missing keys. I separated a build check only for pull requests at #971.

Changes:
	- revert c22c243 (fossasia#936)
	- only ask for Location and show Prominent Disclosure
	on Android 11 and below
@kienvo kienvo force-pushed the fix-ble-android11 branch from 9cbf957 to 730a425 Compare July 6, 2024 15:21
@mariobehling mariobehling merged commit 8c82d7b into fossasia:development Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants