ifx crash: fix fPIC logic

Author: perazz

ci/run_tests.sh

@@ -317,7 +317,7 @@ popd
 
 # Test shared library dependencies
 pushd shared_lib
-"$fpm" build || EXIT_CODE=$?
+"$fpm" build --verbose || EXIT_CODE=$?
 test $EXIT_CODE -eq 0
 popd
 

src/fpm.f90

@@ -12,7 +12,9 @@ module fpm
 use fpm_model, only: fpm_model_t, srcfile_t, show_model, &
                     FPM_SCOPE_UNKNOWN, FPM_SCOPE_LIB, FPM_SCOPE_DEP, &
                     FPM_SCOPE_APP, FPM_SCOPE_EXAMPLE, FPM_SCOPE_TEST
-use fpm_compiler, only: new_compiler, new_archiver, set_cpp_preprocessor_flags
+use fpm_compiler, only: new_compiler, new_archiver, set_cpp_preprocessor_flags, &
+                        id_intel_classic_nix,id_intel_classic_mac,id_intel_llvm_nix, &
+                        id_intel_llvm_unknown
 
 
 use fpm_sources, only: add_executable_sources, add_sources_from_dir
@@ -335,28 +337,46 @@ subroutine new_compiler_flags(model, settings, package)
     type(fpm_build_settings), intent(in) :: settings
     type(package_config_t), intent(in) :: package
 
-    logical :: release_profile, debug_profile
+    logical :: release_request, debug_request, need_defaults
+    character(len=:), allocatable :: fallback
 
-    release_profile = .false.
-      debug_profile = .false.
-    if (allocated(settings%profile)) release_profile = settings%profile == "release"
-    if (allocated(settings%profile))   debug_profile = settings%profile == "debug"
-
-    ! Debug./Release profile requested but not defined: 
-    ! fallback to backward-compatible behavior
-    if (     (release_profile .and. package%find_profile("release")==0) &
-        .or. (debug_profile .and. package%find_profile("debug")==0) ) then 
+    ! Default: "debug" if not requested
+    release_request = .false.
+    debug_request   = .not.allocated(settings%profile)
+    if (allocated(settings%profile)) release_request = settings%profile == "release"
+    if (allocated(settings%profile)) debug_request   = settings%profile == "debug"    
+    
+    need_defaults = release_request .or. debug_request
+    
+    ! Backward-compatible: if debug/release requested, but a user-defined profile is not defined,
+    ! apply fpm compiler defaults
+    if (need_defaults) then 
+        
+        need_defaults   =      (release_request .and. package%find_profile("release")<=0) &
+                          .or. (debug_request .and. package%find_profile("debug")<=0)
 
-        model%fortran_compile_flags = assemble_flags(settings%flag,package%flags,&
-                                                     model%compiler%get_default_flags(release_profile))
+    end if
+    
+    ! Fix: Always include compiler default flags for Intel ifx -fPIC issue
+    if (need_defaults) then 
 
+        fallback = model%compiler%get_default_flags(release_request)
+        
+    elseif (any(model%compiler%id==[id_intel_classic_mac, &
+                                    id_intel_classic_nix, &
+                                    id_intel_llvm_nix, &
+                                    id_intel_llvm_unknown])) then
+
+        ! Intel compilers need -fPIC for shared libraries (except Windows)
+        fallback = " -fPIC"
 
     else
 
-        model%fortran_compile_flags = assemble_flags(settings%flag, package%flags)
+        if (allocated(fallback)) deallocate(fallback) ! trigger .not.present
 
-    end if
-    
+    endif
+        
+    model%fortran_compile_flags = assemble_flags(settings%flag,    package%flags, fallback)
     model%c_compile_flags       = assemble_flags(settings%cflag,   package%c_flags)
     model%cxx_compile_flags     = assemble_flags(settings%cxxflag, package%cxx_flags)
     model%link_flags            = assemble_flags(settings%ldflag,  package%link_time_flags)

src/fpm_targets.f90

@@ -1076,7 +1076,7 @@ end subroutine prune_build_targets
 subroutine resolve_target_linking(targets, model, library, error)
     type(build_target_ptr), intent(inout), target :: targets(:)
     type(fpm_model_t), intent(in) :: model
-    type(library_config_t), intent(in), optional :: library    
+    type(library_config_t), intent(in), optional :: library
     type(error_t), allocatable, intent(out) :: error
 
     integer :: i,j
@@ -1085,8 +1085,10 @@ subroutine resolve_target_linking(targets, model, library, error)
     character(:), allocatable :: global_link_flags, local_link_flags
     character(:), allocatable :: global_include_flags, shared_lib_paths
 
+
     if (size(targets) == 0) return
 
+
     global_link_flags = ""
     if (allocated(model%link_libraries)) then
         if (size(model%link_libraries) > 0) then
@@ -1116,13 +1118,14 @@ subroutine resolve_target_linking(targets, model, library, error)
 
         associate(target => targets(i)%ptr)
 
+
             ! If the main program is a C/C++ one, some compilers require additional linking flags, see
             ! https://stackoverflow.com/questions/36221612/p3dfft-compilation-ifort-compiler-error-multiple-definiton-of-main
             ! In this case, compile_flags were already allocated
             if (.not.allocated(target%compile_flags)) allocate(character(len=0) :: target%compile_flags)
 
             target%compile_flags = target%compile_flags//' '
-            
+
             select case (target%target_type)
                case (FPM_TARGET_C_OBJECT)
                    target%compile_flags = target%compile_flags//model%c_compile_flags
@@ -1141,7 +1144,8 @@ subroutine resolve_target_linking(targets, model, library, error)
             if (len(global_include_flags) > 0) then
                 target%compile_flags = target%compile_flags//global_include_flags
             end if
-            
+
+
             call target%set_output_dir(get_output_dir(model%build_prefix, target%compile_flags))
 
         end associate