Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces on password: limitation on original dropbox zxcvbn implementation #11

Open
formigarafa opened this issue Oct 9, 2023 · 0 comments
Labels
question Further information is requested

Comments

@formigarafa
Copy link
Owner

formigarafa commented Oct 9, 2023

I saw a reference to dropbox/zxcvbn#227 here: https://github.com/18F/identity-idp/blob/main/spec/support/shared_examples/password_strength.rb#L46 which made me curious.

The js source lib seems to have an annoying limitation when passwords being checked include spaces.

Well, annoying only by the fact they no longer update (or publish updates for) it.

I am wondering what can I do to improve the results of the ruby port without breaking compatibility with the original.

@formigarafa formigarafa added the question Further information is requested label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant