Skip to content

Send 400 instead of crashing on undefined index when no data is passe… #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Send 400 instead of crashing on undefined index when no data is passe… #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Controller/AjaxController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;

/**
* These actions call from the client side to check some validations on the server side
Expand All @@ -24,6 +25,10 @@ class AjaxController extends Controller
public function checkUniqueEntityAction(Request $request)
{
$data = $request->request->all();
if (!array_key_exists('data', $data)) {
throw new BadRequestHttpException();
}

foreach ($data['data'] as $value) {
// If field(s) has an empty value and it should be ignored
if ((bool) $data['ignoreNull'] && ('' === $value || is_null($value))) {
Expand Down